Fix trigger ui enum parameter field is a dictionary when param.value is null #58682
+6
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* return 'null' when param.value is null, rather than typeof(null) * added 'null' to list of enum types
Tomi-1997
requested review from
bbovenzi,
guan404ming,
pierrejeambrun,
ryanahamilton and
shubhamraj-git
as code owners
pierrejeambrun
changed the title
pierrejeambrun
added
the
backport-to-v3-1-test
pierrejeambrun
approved these changes
Dec 1, 2025
Member
pierrejeambrun
left a comment
pierrejeambrun
left a comment
There was a problem hiding this comment.
Looks good to me, thanks
pierrejeambrun
changed the title
Backport successfully created: v3-1-test
|
RoyLee1224
pushed a commit
to RoyLee1224/airflow
that referenced
this pull request
Dec 3, 2025
…pache#58682) * return 'null' when param.value is null, rather than typeof(null) * added 'null' to list of enum types
Copilot AI
pushed a commit
to jason810496/airflow
that referenced
this pull request
Dec 5, 2025
…pache#58682) * return 'null' when param.value is null, rather than typeof(null) * added 'null' to list of enum types
itayweb
pushed a commit
to itayweb/airflow
that referenced
this pull request
Dec 6, 2025
…pache#58682) * return 'null' when param.value is null, rather than typeof(null) * added 'null' to list of enum types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #56427
Problem
When an Enum is used as a parameter in a DAG definition with no default value (or any Param, with no value or type), the field is rendered as a dictionary which might be confusing.
This is the trigger form's parameters with an enum with no default values, and an empty paramter.
Solution
Now the enum is a drop down, and the empty parameter is a string field
This solves the enum issue, and addresses null values, yet I am unsure if this should be the intended behavior when handling missing default values. Browsing the docs, Param either has default value, or a type defined.
Anyway, I'm open to ideas!