Skip to content

Mask secrets properly when using deprecated import path #58662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
amoghrajesh merged 1 commit into from
Nov 26, 2025
+9 −1
Merged

Mask secrets properly when using deprecated import path #58662

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion task-sdk/src/airflow/sdk/execution_time/secrets_masker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,17 +27,25 @@

import warnings

# Note: This import from airflow-core is ok, as this is a compatibility module which we will remove in 3.2 anyways
from airflow.utils.deprecation_tools import DeprecatedImportWarning

warnings.warn(
"Importing from 'airflow.sdk.execution_time.secrets_masker' is deprecated and will be removed in a future version. "
"Please use 'airflow.sdk._shared.secrets_masker' instead.",
DeprecationWarning,
DeprecatedImportWarning,
stacklevel=2,
)


def __getattr__(name: str):
"""Dynamically import attributes from the shared secrets_masker location."""
try:
if name == "mask_secret":
from airflow.sdk.log import mask_secret

return mask_secret

import airflow.sdk._shared.secrets_masker as new_module

return getattr(new_module, name)
Expand Down