Make the launcher a cached_property and minor change to improve how pod name is retrieved #58646
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hange to improve how pod name is retrieved in spark_kubernetes.py, add unit tests
Ferdinanddb
requested review from
hussein-awala and
jedcunningham
as code owners
boring-cyborg
bot
added
area:providers
provider:cncf-kubernetes
Nataneljpwd
approved these changes
Nov 25, 2025
Contributor
Nataneljpwd
left a comment
Nataneljpwd
left a comment
There was a problem hiding this comment.
Minor nitpicks, other than that seems good!
providers/cncf/kubernetes/src/airflow/providers/cncf/kubernetes/operators/spark_kubernetes.py
Outdated
Show resolved
Hide resolved
providers/cncf/kubernetes/src/airflow/providers/cncf/kubernetes/operators/spark_kubernetes.py
Outdated
Show resolved
Hide resolved
2 tasks
jscheffl
approved these changes
Nov 29, 2025
Contributor
jscheffl
left a comment
jscheffl
left a comment
There was a problem hiding this comment.
Thanks for the fix, looks good to me!
jscheffl
changed the title
Contributor
|
Adjusted title for better changelog, we do not use conventional commits. |
|
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
2 tasks
70 tasks
RoyLee1224
pushed a commit
to RoyLee1224/airflow
that referenced
this pull request
Dec 3, 2025
…od name is retrieved (apache#58646) * fix(cncf-kubernetes): make the launcher a cached_property and minor change to improve how pod name is retrieved in spark_kubernetes.py, add unit tests * chore: use removesuffix to set self.name and job_name variables as suggested by @Nataneljpwd
Copilot AI
pushed a commit
to jason810496/airflow
that referenced
this pull request
Dec 5, 2025
…od name is retrieved (apache#58646) * fix(cncf-kubernetes): make the launcher a cached_property and minor change to improve how pod name is retrieved in spark_kubernetes.py, add unit tests * chore: use removesuffix to set self.name and job_name variables as suggested by @Nataneljpwd
itayweb
pushed a commit
to itayweb/airflow
that referenced
this pull request
Dec 6, 2025
…od name is retrieved (apache#58646) * fix(cncf-kubernetes): make the launcher a cached_property and minor change to improve how pod name is retrieved in spark_kubernetes.py, add unit tests * chore: use removesuffix to set self.name and job_name variables as suggested by @Nataneljpwd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
launcherobject used to create and delete Kubernetes objects related to Spark.closes: #58228
related: #56291
This PR should fix the issues mentioned above by caching the
launcherobject being used to create and delete Kubernetes objects. Without this PR:reattach_on_restart=Trueis set, theself.launcheris never instantiated and so the error mentioned in the issues is raised.deferrable=True, the worker pod might get deleted while the job is deferred, and when the worker pod is used again to handle the deletion of the pod at the end, then the error mentioned in the issues is raised because theself.launcheris never instantiated.^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.