-
Notifications
You must be signed in to change notification settings - Fork 16.4k
feat(param): add source to Param #58615
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
e5080a3 to
dcc2146
Compare
dcc2146 to
b475c08
Compare
jason810496
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! LGTM overall.
providers/standard/src/airflow/providers/standard/operators/hitl.py
Outdated
Show resolved
Hide resolved
b475c08 to
9469b6b
Compare
airflow-core/src/airflow/api_fastapi/core_api/services/ui/connections.py
Outdated
Show resolved
Hide resolved
9469b6b to
13b59eb
Compare
jason810496
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure whether should this kind of typing be included in shared module to avoid DRY?
Though duplicating might still be the better approach as the typing are too small for shared module as long as we are carful enough for the consistency during review.
Probably not this one 🤔 We might need to deal with version issues with little gain |
…g" for code consistency
… of "Dag" for code consistency
20daf37 to
30b5667
Compare
Why
We merge Dag params and task params as task params, and there's no way to distinguish Dag params and task params. It was by design back then. In most cases, users can ignore the Dag level params if they don't need them. But in some cases, such as HITLOperator, we need to distinguish params from different sources, since the param exists only at the Dag level and has no meaning to them, and causes confusion in the "Required Action" tab.
What
Paramfilter_params_by_sourcetoParamsDictParamsDict.filter_params_by_sourceis availableParam.source^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.