fix: task root in parentRunFacet is not always the same as in dag run #58407
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@mobuchowski I think this is a bug, the task root should always be the same as dag root (even if the dagroot comes from using the parent info as there was no root explicitly specified). LMK if you think otherwise. |
kacpermuda
force-pushed
the
fix-ol-dag-parent-facet
branch
from
e2c23b0 to
88631c7
Compare
kacpermuda
changed the title
mobuchowski
approved these changes
Nov 17, 2025
aaron-wolmutt
pushed a commit
to aaron-wolmutt/airflow
that referenced
this pull request
Nov 20, 2025
62 tasks
itayweb
pushed a commit
to itayweb/airflow
that referenced
this pull request
Dec 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When working on #57809 I missed support for one case. When only parent information is present in DagRun conf, it's used in DagRun parent run facet as parent and root. Currently, it's not propagated to task root - so in that case task's root is always DagRun, as before.
This PR fixes that, now the root in DagRun's parentRunFacet should always be the same as root in Task's parentRunFacet.
This is the test case that checks that specific scenario:
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.