Skip to content

[v3-1-test] Add check for schedule parameter for system tests (#58254) #58255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
potiuk merged 1 commit into from
Nov 13, 2025
Merged

[v3-1-test] Add check for schedule parameter for system tests (#58254) #58255

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 29 additions & 0 deletions scripts/ci/prek/check_system_tests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,9 +55,38 @@
r"test_run = get_test_run"
)

DAG_WITH_ARGS = re.compile(
r"with\s+DAG\s*\(\s*(?P<args>.*?)\)\s*as\s+\w+\s*:",
re.DOTALL,
)
REQUIRES_SCHEDULE_ERROR = (
"[red]System test DAG must set the 'schedule' parameter (e.g. schedule='@once').[/]\n\n"
"[yellow]Example:[/]\n\n"
"with DAG(\n"
" DAG_ID,\n"
" schedule='@once',\n"
" start_date=datetime(2021, 1, 1),\n"
" catchup=False,\n"
" tags=[...],\n"
") as dag:\n"
)


def _check_file(file: Path):
content = file.read_text()
console.print("----------file path: ", file)
for m in DAG_WITH_ARGS.finditer(content):
args = m.group("args")
if "schedule" not in args:
errors.append(
f"In {file}: System test DAG must include the 'schedule' parameter "
f"(e.g. schedule='@once') inside DAG(...).\n"
)
elif "providers/google/" in str(file).replace("\\", "/") and "schedule=None" in args:
errors.append(
f"In {file}: System test DAG should not include the 'schedule' parameter "
f"with value 'None' inside DAG(...): this configuration will make the automated run not possible for the test.\n"
)
if "from tests_common.test_utils.watcher import watcher" in content:
index = content.find(WATCHER_APPEND_INSTRUCTION_SHORT)
if index == -1:
Expand Down