Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions airflow-core/src/airflow/models/dag.py
Original file line number Diff line number Diff line change
Expand Up @@ -131,9 +131,14 @@ def get_run_data_interval(timetable: Timetable, run: DagRun) -> DataInterval:

:meta private:
"""
data_interval = _get_model_data_interval(run, "data_interval_start", "data_interval_end")
if data_interval is not None:
if (
data_interval := _get_model_data_interval(run, "data_interval_start", "data_interval_end")
) is not None:
return data_interval

if (data_interval := timetable.infer_manual_data_interval(run_after=run.run_after)) is not None:
return data_interval

# Compatibility: runs created before AIP-39 implementation don't have an
# explicit data interval. Try to infer from the logical date.
return infer_automated_data_interval(timetable, run.logical_date)
Expand Down
34 changes: 34 additions & 0 deletions airflow-core/tests/unit/models/test_dag.py
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@
DagTag,
get_asset_triggered_next_run_info,
get_next_data_interval,
get_run_data_interval,
)
from airflow.models.dagbag import DBDagBag
from airflow.models.dagbundle import DagBundleModel
Expand Down Expand Up @@ -3447,3 +3448,36 @@ def hello():

# but it only gets stamped on the dag run when bundle versioning not disabled
assert dr.bundle_version == expected


def test_get_run_data_interval():
with DAG("dag", schedule=None, start_date=DEFAULT_DATE) as dag:
EmptyOperator(task_id="empty_task")

dr = _create_dagrun(
dag,
logical_date=timezone.utcnow(),
data_interval=(DEFAULT_DATE, DEFAULT_DATE),
run_type=DagRunType.MANUAL,
)
assert get_run_data_interval(dag.timetable, dr) == DataInterval(start=DEFAULT_DATE, end=DEFAULT_DATE)


def test_get_run_data_interval_pre_aip_39():
with DAG(
"dag",
schedule="0 0 * * *",
start_date=DEFAULT_DATE,
) as dag:
EmptyOperator(task_id="empty_task")

current_ts = timezone.utcnow()
dr = _create_dagrun(
dag,
logical_date=current_ts,
data_interval=(None, None),
run_type=DagRunType.MANUAL,
)
ds_start = current_ts.replace(hour=0, minute=0, second=0, microsecond=0) - timedelta(days=1)
ds_end = current_ts.replace(hour=0, minute=0, second=0, microsecond=0)
assert get_run_data_interval(dag.timetable, dr) == DataInterval(start=ds_start, end=ds_end)