Add database cleanup cronjob to clean old records #58155
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ronaldorcampos
requested review from
dstandish,
hussein-awala,
jedcunningham and
jscheffl
as code owners
ronaldorcampos
changed the title
jscheffl
approved these changes
Nov 12, 2025
Contributor
jscheffl
left a comment
jscheffl
left a comment
There was a problem hiding this comment.
Looks good in my view. Static check failure is from another problem on main, seems unrelated to this PR.
Keeping this PR open a few days in other leaving a second pass review.
ronaldorcampos
force-pushed
the
feature/cleanup
branch
from
baa8d50 to
8281c58
Compare
Contributor
Author
|
Thanks for the review @jscheffl |
jscheffl
approved these changes
Nov 13, 2025
ronaldorcampos
force-pushed
the
feature/cleanup
branch
from
96a1dec to
54adf9f
Compare
Contributor
Author
|
Tests, linting should be fixed now, sorry! |
ronaldorcampos
force-pushed
the
feature/cleanup
branch
2 times, most recently
from
d8bdeb4 to
a5fe26e
Compare
ronaldorcampos
force-pushed
the
feature/cleanup
branch
from
a5fe26e to
42bac90
Compare
Member
jedcunningham
left a comment
jedcunningham
left a comment
There was a problem hiding this comment.
Nice! Thanks for the PR. Noticed a few minor things.
chart/templates/database-cleanup/database-cleanup-serviceaccount.yaml
Outdated
Show resolved
Hide resolved
helm-tests/tests/helm_tests/airflow_aux/test_database_cleanup_pods.py
Outdated
Show resolved
Hide resolved
helm-tests/tests/helm_tests/airflow_aux/test_database_cleanup_pods.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Jed Cunningham <66968678+jedcunningham@users.noreply.github.com>
…pods.py Co-authored-by: Jed Cunningham <66968678+jedcunningham@users.noreply.github.com>
…pods.py Co-authored-by: Jed Cunningham <66968678+jedcunningham@users.noreply.github.com>
Co-authored-by: Jed Cunningham <66968678+jedcunningham@users.noreply.github.com>
# Conflicts: # helm-tests/tests/helm_tests/security/test_scc_rolebinding.py
Contributor
Author
|
thanks for the review @jedcunningham. I will open a PR for some changes with cleanup cronjob and also add this #58155 (comment) change too |
jedcunningham
approved these changes
Nov 24, 2025
Member
|
Thanks @rcampos87! |
itayweb
pushed a commit
to itayweb/airflow
that referenced
this pull request
Dec 6, 2025
96 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR creates a new database clean up cronjob that runs
airflow db clean, it runs by default every week, specified byschedule, and deletes records on the metadata db before X days, specified byretentionDays.This will be helpful to those who want to keep the metadata db lean and dont want to go the extra length and setup a manual cronjob.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.