Migrate FAB PATCH /roles/{name} to FastAPI #58023
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Some conflicts as well |
kyounghunJang
force-pushed
the
fab-roles-patch
branch
from
59afddf to
a2efc82
Compare
Contributor
Author
@vincbeck |
potiuk
approved these changes
Nov 16, 2025
Member
|
Does it mean we can finally remove connexion as FAB dependency @kyounghunJang ???? 👯 ? |
Contributor
Author
@potiuk |
Member
|
So ... no 👯 yet :) |
Contributor
Author
aaron-wolmutt
pushed a commit
to aaron-wolmutt/airflow
that referenced
this pull request
Nov 20, 2025
62 tasks
itayweb
pushed a commit
to itayweb/airflow
that referenced
this pull request
Dec 6, 2025
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Align FAB provider with Airflow 3’s FastAPI-first direction and continue removing remaining Connexion/Flask surface.
This PR is a follow-up for issue Replace connexion with fast-api for FAB provider (#56730) by migrating a single endpoint PATCH /auth/fab/v1/roles/{name}.
How
New FastAPI endpoint
Implemented PATCH /auth/fab/v1/roles/{name} on the FAB router with 200 OK on success
Path parameter
name: str — required, validated with min_length=1.
Query Parameter
update_mask - Optional
Service logic
Added patch_role(name: str, body: RoleBody, update_mask: str ) method to FABAuthManagerRoles service class.
Tests
Added route tests for
PATCH /roles/{name}
success (200)
bad request (400)
unauthorized (403)
not found (404)