feat: added toasters for permission denied (#57966) #58016
Conversation
aaron-wolmutt
requested review from
bbovenzi,
guan404ming,
pierrejeambrun,
ryanahamilton and
shubhamraj-git
as code owners
|
@aaron-wolmutt - just to confirm, the "Trigger" button is greyed out as soon when the pop-up initially opens? Or does it "grey out" after they try to trigger it for the first time? |
It only adds the toaster in the bottom right. |
@jroachgolf84 I added the "grey out" in the last commit. 
|
aaron-wolmutt
force-pushed
the
feat-unauthorized-dag-run
branch
from
0b18963 to
e68ea2c
Compare
@pierrejeambrun I marked this as ready for review. Should the error alert be removed from the bottom of the trigger dag form too? |
|
Here is the behavior of the permissions denied with the grey out
|
aaron-wolmutt
force-pushed
the
feat-unauthorized-dag-run
branch
from
7622399 to
4160373
Compare
pierrejeambrun
left a comment
pierrejeambrun
left a comment
There was a problem hiding this comment.
Last nit, looking good to me.
aaron-wolmutt
changed the title
* feat: add http error validation and toasters for permission denied * disable trigger dag button if the useTrigger hook returns an error * fix lint * ci: ran prek hooks * ci: fix linting * fix toaster error handling. added toaster error translations json * removed error util. refactored to use generic error * remove deleted utility import * remove generic from triggerDag.toaster.error translation
* feat: add http error validation and toasters for permission denied * disable trigger dag button if the useTrigger hook returns an error * fix lint * ci: ran prek hooks * ci: fix linting * fix toaster error handling. added toaster error translations json * removed error util. refactored to use generic error * remove deleted utility import * remove generic from triggerDag.toaster.error translation (cherry picked from commit ba7e2fb)
|
Manual backport: |
* feat: add http error validation and toasters for permission denied * disable trigger dag button if the useTrigger hook returns an error * fix lint * ci: ran prek hooks * ci: fix linting * fix toaster error handling. added toaster error translations json * removed error util. refactored to use generic error * remove deleted utility import * remove generic from triggerDag.toaster.error translation (cherry picked from commit ba7e2fb) Co-authored-by: Aaron Wolmutt <163314771+aaron-wolmutt@users.noreply.github.com>
4 participants
Add http error validation when running a dag. Displays toasters if the user is forbidden, unauthorized, or a generic error occurs.
Response to #57966