Skip to content

Add LIST permission to admin role in Keycloak auth manager #57978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vincbeck merged 1 commit into from
Nov 6, 2025
Merged

Add LIST permission to admin role in Keycloak auth manager #57978

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion providers/keycloak/src/airflow/providers/keycloak/auth_manager/cli/commands.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,8 @@ def _create_read_only_permission(client: KeycloakAdmin, client_uuid: str):

def _create_admin_permission(client: KeycloakAdmin, client_uuid: str):
all_scopes = client.get_client_authz_scopes(client_uuid)
scopes = [scope["id"] for scope in all_scopes if scope["name"] in get_args(ExtendedResourceMethod)]
scope_names = get_args(ExtendedResourceMethod) + ("LIST",)
scopes = [scope["id"] for scope in all_scopes if scope["name"] in scope_names]
payload = {
"name": "Admin",
"type": "scope",
Expand Down
1 change: 1 addition & 0 deletions providers/keycloak/src/airflow/providers/keycloak/auth_manager/keycloak_auth_manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,7 @@ def get_url_login(self, **kwargs) -> str:

def refresh_user(self, *, user: KeycloakAuthManagerUser) -> KeycloakAuthManagerUser | None:
if self._token_expired(user.access_token):
log.debug("Refreshing the token")
client = self.get_keycloak_client()
tokens = client.refresh_token(user.refresh_token)
user.refresh_token = tokens["refresh_token"]
Expand Down
10 changes: 8 additions & 2 deletions providers/keycloak/tests/unit/keycloak/auth_manager/cli/test_commands.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -277,7 +277,13 @@ def test_create_permissions_read_only(self):

def test_create_permissions_admin(self):
client = Mock()
scopes = [{"id": "1", "name": "GET"}, {"id": "2", "name": "MENU"}, {"id": "3", "name": "PUT"}]
scopes = [
{"id": "1", "name": "GET"},
{"id": "2", "name": "MENU"},
{"id": "3", "name": "PUT"},
{"id": "4", "name": "LIST"},
{"id": "5", "name": "DUMMY"},
]

client.get_client_authz_scopes.return_value = scopes

Expand All @@ -291,7 +297,7 @@ def test_create_permissions_admin(self):
"type": "scope",
"logic": "POSITIVE",
"decisionStrategy": "UNANIMOUS",
"scopes": ["1", "2", "3"],
"scopes": ["1", "2", "3", "4"],
},
)

Expand Down