Synchronize default versions in all split .pre-commit-config.yaml #57851
Conversation
potiuk
requested review from
amoghrajesh,
ashb,
bugraoz93,
dstandish,
hussein-awala,
jedcunningham,
jscheffl,
kaxil and
vincbeck
as code owners
boring-cyborg
bot
added
area:airflow-ctl
area:dev-tools
area:go-sdk
area:helm-chart
We should make sure that defaults are also specified in the split .pre-commit-config.yaml files for different languages. Just to avoid any future problems we synchronize defaults for all languages no matter which languages are used currently - because it is possible that we will use different languages in different distributions for pre-commits.
potiuk
force-pushed
the
fix-default-language-versions
branch
from
ed194a2 to
691438f
Compare
|
Do we have a pre-commit check to check those pre-commit configs are in sync with each other? |
|
@uranusjr you mean this? |
I think not - but that would be somewhat valuable addition if you would like to add one (however we change those very rarely). |
Backport failed to create: v3-1-test. View the failure log Run details
You can attempt to backport this manually by running: cherry_picker e67b211 v3-1-testThis should apply the commit to the v3-1-test branch and leave the commit in conflict state marking After you have resolved the conflicts, you can continue the backport process by running: cherry_picker --continue |
|
So feel absolutely free @uranusjr 
|
|
No need to backport BTW. |
| default_language_version: | ||
| python: python3 | ||
| node: 22.19.0 | ||
| golang: 1.24.0 |
There was a problem hiding this comment.
Interesting, also if there is no golang in this package :-D
There was a problem hiding this comment.
Yes. I wrote it in the description that I am adding all defaults everywhere - it is very easy to add or move a peek hook and forget toove defaults.
Defaults are just defaults :)
…ache#57851) We should make sure that defaults are also specified in the split .pre-commit-config.yaml files for different languages. Just to avoid any future problems we synchronize defaults for all languages no matter which languages are used currently - because it is possible that we will use different languages in different distributions for pre-commits.
5 participants
We should make sure that defaults are also specified in the split .pre-commit-config.yaml files for different languages. Just to avoid any future problems we synchronize defaults for all languages no matter which languages are used currently - because it is possible that we will use different languages in different distributions for pre-commits.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.