Correcting distribution name while prepping package #57848
Conversation
amoghrajesh
requested review from
ashb,
bugraoz93,
eladkal,
ephraimbuddy,
gopidesupavan,
jason810496,
jedcunningham,
jscheffl,
kaxil and
potiuk
as code owners
boring-cyborg
bot
added
area:dev-tools
backport-to-v3-1-test
|
@ephraimbuddy I noticed this one today while testing the RC |
Update distribution name in Airflow release instructions.
| breeze release-management prepare-airflow-distributions --distribution-format both | ||
| breeze release-management prepare-task-sdk-distributions --distribution-format both | ||
| breeze release-management prepare-airflow-tarball --version ${VERSION} --distribution-name apache_airflow | ||
| breeze release-management prepare-airflow-tarball --version ${VERSION} --distribution-name airflow |
There was a problem hiding this comment.
What effect does this have on the wheel? What is it now with this change?
There was a problem hiding this comment.
apache_airflow isn't a valid option for --distribution-name, it prepares it rightly, as I tested today
There was a problem hiding this comment.
Yes, but what filename does it produce I mean?
Shouldn't this be apache-airflow or something? (We don't upload to PyPi as airflow)
There was a problem hiding this comment.
It should produce: apache-airflow-[version] tarball right?
➜ dist git:(retries-bug-dag) ✗ ls
apache_airflow_core-3.1.2-py3-none-any.whl apache_airflow_task_sdk-1.1.2-py3-none-any.whl apache_airflow-3.1.2-py3-none-any.whl apache-airflow-3.1.2-source.tar.gz
apache_airflow_core-3.1.2.tar.gz apache_airflow_task_sdk-1.1.2.tar.gz apache_airflow-3.1.2.tar.gz
There was a problem hiding this comment.
The #57901 contains much more comprehensive improvements - there were a number of somewhat badly used flags there
The flag is now --tarball-type rather than distribution name.
The source tarballs are now produced with the right name and versions, and they are also easy to run locally without creating a tag first. also internal structure is as expected by the Apache Trusted Releases (see https://release-test.apache.org/finish/airflow-ctl/0.1.0) also opened few issues in ATR that need to be fixed:
- Unclear version to be used (0.1.0 or 0.1.0rc1) ? tooling-trusted-releases#292
- Seeing preview of the mail tooling-trusted-releases#293
- Root directory not matching ? Should we always use -source ? tooling-trusted-releases#294
- Rat check / Licence Headers check tooling-trusted-releases#296
And resulting first tasks in ATR are added now:
There was a problem hiding this comment.
Shouldn't this be apache-airflow or something? (We don't upload to PyPi as airflow)
Yep. that is exactly what --tarball-type is modelled for:
It should be much cleaner and consistent now (and ATR ready 🤞 )
There was a problem hiding this comment.
Okay thats nicer! Thanks
4 participants
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.