Skip to content

Enable ruff PLW1508 rule #57653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jscheffl merged 1 commit into from
Nov 1, 2025
Merged

Enable ruff PLW1508 rule #57653

jscheffl merged 1 commit into from
Nov 1, 2025

Conversation

@jscheffl
Copy link
Contributor

@jscheffl jscheffl commented Oct 31, 2025

While implementing #57294 I realized that a couple of more ruff PLW rules might be interesting, this PR enables PLW1508 - and adds fixes as needed.

Alongside saw that the following needed no fixes and enabled them as well:

  • PLW0604: global at module level is redundant
  • PLW0642: Reassigned {} variable in {method_type} method
  • PLW0711: Exception to catch is the result of a binary and operation
  • PLW1501: {mode} is not a valid mode for open
  • PLW1507: Shallow copy of os.environ via copy.copy(os.environ)

See also https://docs.astral.sh/ruff/rules/#warning-plw

@boring-cyborg boring-cyborg bot added area:API Airflow's REST/HTTP API area:dev-tools area:docker-tests area:production-image Production image improvements and fixes area:providers backport-to-v3-1-test Mark PR with this label to backport to v3-1-test branch provider:amazon AWS/Amazon - related issues provider:databricks provider:edge Edge Executor / Worker (AIP-69) / edge3 provider:google Google (including GCP) related issues provider:microsoft-azure Azure-related issues labels Oct 31, 2025
jason810496
jason810496 approved these changes Nov 1, 2025
View reviewed changes
Copy link
Member

@jason810496 jason810496 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@jscheffl jscheffl merged commit c846f6f into apache:main Nov 1, 2025
405 of 407 checks passed
@github-actions
Copy link

github-actions bot commented Nov 1, 2025

Backport failed to create: v3-1-test. View the failure log Run details

Status Branch Result
❌ v3-1-test Commit Link

You can attempt to backport this manually by running:

cherry_picker c846f6f v3-1-test

This should apply the commit to the v3-1-test branch and leave the commit in conflict state marking
the files that need manual conflict resolution.

After you have resolved the conflicts, you can continue the backport process by running:

cherry_picker --continue

jscheffl added a commit to jscheffl/airflow that referenced this pull request Nov 1, 2025
@jscheffl
[v3-1-test] Enable ruff PLW1508 rule (apache#57653)
7eebd29 
(cherry picked from commit c846f6f)

Co-authored-by: Jens Scheffler <95105677+jscheffl@users.noreply.github.com>
jscheffl added a commit that referenced this pull request Nov 1, 2025
@jscheffl
[v3-1-test] Enable ruff PLW1508 rule (#57653) (#57673)
a4251da 
(cherry picked from commit c846f6f)
ephraimbuddy pushed a commit that referenced this pull request Nov 3, 2025
@jscheffl @ephraimbuddy
[v3-1-test] Enable ruff PLW1508 rule (#57653) (#57673)
2792668 
(cherry picked from commit c846f6f)
ephraimbuddy pushed a commit that referenced this pull request Nov 4, 2025
@jscheffl @ephraimbuddy
[v3-1-test] Enable ruff PLW1508 rule (#57653) (#57673)
3ceb366 
(cherry picked from commit c846f6f)
Copilot AI pushed a commit to jason810496/airflow that referenced this pull request Dec 5, 2025
@jscheffl
Enable ruff PLW1508 rule (apache#57653)
790470d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bugraoz93 bugraoz93 bugraoz93 approved these changes

@eladkal eladkal eladkal approved these changes

@jason810496 jason810496 jason810496 approved these changes

@potiuk potiuk Awaiting requested review from potiuk potiuk is a code owner

@ashb ashb Awaiting requested review from ashb ashb is a code owner

@gopidesupavan gopidesupavan Awaiting requested review from gopidesupavan gopidesupavan is a code owner

@amoghrajesh amoghrajesh Awaiting requested review from amoghrajesh amoghrajesh is a code owner

@kaxil kaxil Awaiting requested review from kaxil kaxil is a code owner

@jedcunningham jedcunningham Awaiting requested review from jedcunningham jedcunningham is a code owner

@ephraimbuddy ephraimbuddy Awaiting requested review from ephraimbuddy ephraimbuddy is a code owner

@o-nikolas o-nikolas Awaiting requested review from o-nikolas o-nikolas is a code owner

@vincbeck vincbeck Awaiting requested review from vincbeck vincbeck is a code owner

@pierrejeambrun pierrejeambrun Awaiting requested review from pierrejeambrun pierrejeambrun is a code owner

@rawwar rawwar Awaiting requested review from rawwar rawwar is a code owner

@shubhamraj-git shubhamraj-git Awaiting requested review from shubhamraj-git shubhamraj-git is a code owner

Assignees

No one assigned

Labels

area:API Airflow's REST/HTTP API area:dev-tools area:docker-tests area:production-image Production image improvements and fixes area:providers backport-to-v3-1-test Mark PR with this label to backport to v3-1-test branch provider:amazon AWS/Amazon - related issues provider:databricks provider:edge Edge Executor / Worker (AIP-69) / edge3 provider:google Google (including GCP) related issues provider:microsoft-azure Azure-related issues

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jscheffl @bugraoz93 @eladkal @jason810496