[v3-1-test] Fix: Prevent AttributeError crash in prek when run inside container (#57497) #57649
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… container (#57497) * Revert virtualenv connections/variables access and logging as test are failing Revert virtualenv connections/variables access and logging as tests are failing in https://github.com/apache/airflow/actions/runs/18896380254. The issue here is that it's a socket initialisation error that occurs when CommsDecoder tries to create a socket from stdin (file descriptor 0) in subprocess environments where stdin is not a socket. This reverts commit fb8b590 (PR #57213) which allowed virtualenv code to access connections/variables and send logs via supervisor comms reinitialization. * Address review: Use built-in print as fallback --------- (cherry picked from commit 5002660) Co-authored-by: Gurram Sai Ganesh <gurramsaiganesh93@gmail.com> Co-authored-by: Ankit Chaurasia <8670962+sunank200@users.noreply.github.com>
boring-cyborg
bot
added
area:dev-tools
backport-to-v3-1-test
jscheffl
requested review from
amoghrajesh,
ashb,
bugraoz93,
eladkal,
gopidesupavan,
jason810496,
jscheffl,
kaxil and
potiuk
as code owners
ephraimbuddy
pushed a commit
that referenced
this pull request
Nov 3, 2025
… container (#57497) (#57649) * Revert virtualenv connections/variables access and logging as test are failing Revert virtualenv connections/variables access and logging as tests are failing in https://github.com/apache/airflow/actions/runs/18896380254. The issue here is that it's a socket initialisation error that occurs when CommsDecoder tries to create a socket from stdin (file descriptor 0) in subprocess environments where stdin is not a socket. This reverts commit fb8b590 (PR #57213) which allowed virtualenv code to access connections/variables and send logs via supervisor comms reinitialization. * Address review: Use built-in print as fallback --------- (cherry picked from commit 5002660) Co-authored-by: Gurram Sai Ganesh <gurramsaiganesh93@gmail.com> Co-authored-by: Ankit Chaurasia <8670962+sunank200@users.noreply.github.com>
ephraimbuddy
pushed a commit
that referenced
this pull request
Nov 4, 2025
… container (#57497) (#57649) * Revert virtualenv connections/variables access and logging as test are failing Revert virtualenv connections/variables access and logging as tests are failing in https://github.com/apache/airflow/actions/runs/18896380254. The issue here is that it's a socket initialisation error that occurs when CommsDecoder tries to create a socket from stdin (file descriptor 0) in subprocess environments where stdin is not a socket. This reverts commit fb8b590 (PR #57213) which allowed virtualenv code to access connections/variables and send logs via supervisor comms reinitialization. * Address review: Use built-in print as fallback --------- (cherry picked from commit 5002660) Co-authored-by: Gurram Sai Ganesh <gurramsaiganesh93@gmail.com> Co-authored-by: Ankit Chaurasia <8670962+sunank200@users.noreply.github.com>
ephraimbuddy
added
the
changelog:skip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert virtualenv connections/variables access and logging as tests are failing in https://github.com/apache/airflow/actions/runs/18896380254. The issue here is that it's a socket initialisation error that occurs when CommsDecoder tries to create a socket from stdin (file descriptor 0) in subprocess environments where stdin is not a socket.
This reverts commit fb8b590 (PR #57213) which allowed virtualenv code to access connections/variables and send logs via supervisor comms reinitialization.
(cherry picked from commit 5002660)
Co-authored-by: Gurram Sai Ganesh gurramsaiganesh93@gmail.com
Co-authored-by: Ankit Chaurasia 8670962+sunank200@users.noreply.github.com