Skip to content

Conversation

@tirkarthi
Copy link
Contributor

  • In order to show the count of import errors the API call is made with default limit value and then total_entries is the value used with rest of the response unused. Using limit as 1 fetches only one entry but the total_entries remains the same. In an instance with 500 dag import errors 1.46 kB (25.23kB uncompressed) in 268ms became 539 bytes (543 bytes uncompressed) in 50ms.
  • Don't fetch import errors until the modal is open. This opens up a slot in browser to be used for another request during dashboard and dags list page.
  • In order to check for auto refresh in case of pending runs the queries are made to fetch dagruns in running or queued state. The default limit fetches the dagrun entries which are not used in the UI. Similar to import errors use limit 1 can be used since the underlying check is only about being greater than zero for auto refresh. In scenarios with many running/queued dagruns this will result in efficient decision about whether to auto refresh or not since only one entry needs to be fetched to make the decision. It also reduces the amount of rows fetched from database. In an instance with 8 dagruns in running state 1.85kB (19.49 kB uncompressed) in 300ms became 570 bytes (800 bytes uncompressed) in 170ms.

…I shows total_entries value and rest of the response is ignored.
@boring-cyborg boring-cyborg bot added the area:UI Related to UI/UX. For Frontend Developers. label Oct 31, 2025
@bbovenzi bbovenzi modified the milestones: Airflow 3.1.2, Airflow 3.1.3 Nov 3, 2025
@bbovenzi bbovenzi added the backport-to-v3-1-test Mark PR with this label to backport to v3-1-test branch label Nov 3, 2025
@bbovenzi bbovenzi merged commit c1162b0 into apache:main Nov 3, 2025
60 checks passed
github-actions bot pushed a commit that referenced this pull request Nov 3, 2025
… since the UI shows total_entries value and rest of the response is ignored. (#57624)

(cherry picked from commit c1162b0)

Co-authored-by: Karthikeyan Singaravelan <tir.karthi@gmail.com>
@github-actions
Copy link

github-actions bot commented Nov 3, 2025

Backport successfully created: v3-1-test

Status Branch Result
v3-1-test PR Link

pierrejeambrun pushed a commit that referenced this pull request Nov 5, 2025
… since the UI shows total_entries value and rest of the response is ignored. (#57624)

(cherry picked from commit c1162b0)

Co-authored-by: Karthikeyan Singaravelan <tir.karthi@gmail.com>
bbovenzi added a commit that referenced this pull request Nov 5, 2025
… since the UI shows total_entries value and rest of the response is ignored. (#57624) (#57757)

* [v3-1-test] Don't fetch ImportError until modal opens. Use limit as 1 since the UI shows total_entries value and rest of the response is ignored. (#57624)
(cherry picked from commit c1162b0)

Co-authored-by: Karthikeyan Singaravelan <tir.karthi@gmail.com>

* Fix props order

---------

Co-authored-by: Karthikeyan Singaravelan <tir.karthi@gmail.com>
Co-authored-by: Brent Bovenzi <brent.bovenzi@gmail.com>
ephraimbuddy pushed a commit that referenced this pull request Nov 10, 2025
… since the UI shows total_entries value and rest of the response is ignored. (#57624) (#57757)

* [v3-1-test] Don't fetch ImportError until modal opens. Use limit as 1 since the UI shows total_entries value and rest of the response is ignored. (#57624)
(cherry picked from commit c1162b0)

Co-authored-by: Karthikeyan Singaravelan <tir.karthi@gmail.com>

* Fix props order

---------

Co-authored-by: Karthikeyan Singaravelan <tir.karthi@gmail.com>
Co-authored-by: Brent Bovenzi <brent.bovenzi@gmail.com>
Copilot AI pushed a commit to jason810496/airflow that referenced this pull request Dec 5, 2025
…I shows total_entries value and rest of the response is ignored. (apache#57624)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:UI Related to UI/UX. For Frontend Developers. backport-to-v3-1-test Mark PR with this label to backport to v3-1-test branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants