Skip to content

[v3-1-test] Add number of queries guard in public import errors list endpoints (#57557) #57569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kaxil merged 1 commit into from
Oct 30, 2025
Merged

[v3-1-test] Add number of queries guard in public import errors list endpoints (#57557) #57569

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions airflow-core/tests/unit/api_fastapi/core_api/routes/public/test_import_error.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@
from airflow.models.errors import ParseImportError
from airflow.utils.session import NEW_SESSION, provide_session

from tests_common.test_utils.asserts import assert_queries_count
from tests_common.test_utils.db import clear_db_dag_bundles, clear_db_dags, clear_db_import_errors
from tests_common.test_utils.format_datetime import from_datetime_to_zulu_without_ms

Expand Down Expand Up @@ -322,7 +323,8 @@ def test_get_import_errors(
expected_total_entries,
expected_filenames,
):
response = test_client.get("/importErrors", params=query_params)
with assert_queries_count(2):
response = test_client.get("/importErrors", params=query_params)

assert response.status_code == expected_status_code
if expected_status_code != 200:
Expand Down Expand Up @@ -372,7 +374,8 @@ def test_user_can_not_read_all_dags_in_file(
mock_get_auth_manager, batch_is_authorized_dag_return_value
)
# Act
response = test_client.get("/importErrors")
with assert_queries_count(3):
response = test_client.get("/importErrors")
# Assert
mock_get_authorized_dag_ids.assert_called_once_with(method="GET", user=mock.ANY)
assert response.status_code == 200
Expand Down