[API] Use BulkTaskInstanceBody for patching tis with new state #57226
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prajwal7842
requested review from
bugraoz93,
ephraimbuddy,
jason810496,
pierrejeambrun,
rawwar and
shubhamraj-git
as code owners
Prajwal7842
force-pushed
the
issue_57101
branch
from
f36353c to
e5c2af9
Compare
Prajwal7842
force-pushed
the
issue_57101
branch
from
e5c2af9 to
5b4605c
Compare
Contributor
Author
|
Hi @bugraoz93 can you please review the PR, when available. All checks are passing now. Thank you. |
jason810496
approved these changes
Oct 27, 2025
Member
jason810496
left a comment
jason810496
left a comment
There was a problem hiding this comment.
Nice! Thanks for the good catch!
Member
|
I forgot to add backport label before merging. I will manually backport later on. |
jason810496
pushed a commit
to jason810496/airflow
that referenced
this pull request
Oct 28, 2025
…state (apache#57226) (cherry picked from commit 63b4751) Co-authored-by: Prajwal7842 <34996624+Prajwal7842@users.noreply.github.com>
jason810496
added a commit
that referenced
this pull request
Oct 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates patchTaskInstace API to use map_index when updating the ti states. For dynamic tasks, map_index was not getting honoured due to the use of PatchTaskInstanceBody (which lacks map_index attribute).
Closes 57061
Logic: Previously PatchTaskInstanceBody model was being passed _patch_task_instance_state method, which lacks map_index information. To fix this issue, BulkTaskInstanceBody model is implemented and used instead