Skip to content

Fix iterating through ObjectStoragePath #57156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bolkedebruin merged 1 commit into from
Oct 26, 2025
Merged

Fix iterating through ObjectStoragePath #57156

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions task-sdk/src/airflow/sdk/io/path.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,11 @@ def wrapper(*args, **kwargs):

return wrapper

# We need to explicitly implement `__iter__`
# because otherwise python iteration logic could use `__getitem__`
def __iter__(self):
return iter(self._obj)

def __getitem__(self, key):
# Intercept item access
return self._obj[key]
Expand Down
9 changes: 9 additions & 0 deletions task-sdk/tests/task_sdk/io/test_path.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,6 +215,15 @@ def test_read_write(self, target):
assert o.open("rb").read() == b"foo"
o.unlink()

def test_read_line_by_line(self, target):
o = ObjectStoragePath(f"file://{target}")
with o.open("wb") as f:
f.write(b"foo\nbar\n")
with o.open("rb") as f:
lines = list(f)
assert lines == [b"foo\n", b"bar\n"]
o.unlink()

def test_stat(self, target):
o = ObjectStoragePath(f"file://{target}")
assert o.stat().st_size == 0
Expand Down