Skip to content

improve deferrable KPO handling of deleted pods in between polls #56976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ashb merged 4 commits into from
Oct 28, 2025
Merged

improve deferrable KPO handling of deleted pods in between polls #56976

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a45e522
refactor: log exception in KubernetesPodTrigger
m1racoli Oct 21, 2025
f2ea59b
refactor: log poll_interval on trigger start
m1racoli Oct 21, 2025
73a8bb9
fix: handle missing pod when trying to cleanup after trigger reentry
m1racoli Oct 21, 2025
e6f4795
fix: don't use structured logging when logging poll interval
m1racoli Oct 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions providers/cncf/kubernetes/src/airflow/providers/cncf/kubernetes/operators/pod.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -967,6 +967,10 @@ def trigger_reentry(self, context: Context, event: dict[str, Any]) -> Any:
def _clean(self, event: dict[str, Any], result: dict | None, context: Context) -> None:
if event["status"] == "running":
return

if self.pod is None:
return

istio_enabled = self.is_istio_enabled(self.pod)
# Skip await_pod_completion when the event is 'timeout' due to the pod can hang
# on the ErrImagePull or ContainerCreating step and it will never complete
Expand Down
12 changes: 11 additions & 1 deletion providers/cncf/kubernetes/src/airflow/providers/cncf/kubernetes/triggers/pod.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,12 @@ def serialize(self) -> tuple[str, dict[str, Any]]:

async def run(self) -> AsyncIterator[TriggerEvent]:
"""Get current pod status and yield a TriggerEvent."""
self.log.info("Checking pod %r in namespace %r.", self.pod_name, self.pod_namespace)
self.log.info(
"Checking pod %r in namespace %r with poll interval %r.",
self.pod_name,
self.pod_namespace,
self.poll_interval,
)
try:
state = await self._wait_for_pod_start()
if state == ContainerState.TERMINATED:
Expand Down Expand Up @@ -183,6 +188,11 @@ async def run(self) -> AsyncIterator[TriggerEvent]:
)
return
except Exception as e:
self.log.exception(
"Unexpected error while waiting for pod %s in namespace %s",
self.pod_name,
self.pod_namespace,
)
yield TriggerEvent(
{
"name": self.pod_name,
Expand Down