Skip to content

Conversation

@ramitkataria
Copy link
Contributor


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@github-actions
Copy link

github-actions bot commented Dec 5, 2025

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale Stale PRs per the .github/workflows/stale.yml policy file label Dec 5, 2025
@github-actions github-actions bot closed this Dec 10, 2025
@o-nikolas
Copy link
Contributor

o-nikolas commented Dec 10, 2025

@ramitkataria Are you still working on this? It was marked as stale and autoclosed

@o-nikolas o-nikolas reopened this Dec 10, 2025
@github-actions github-actions bot removed the stale Stale PRs per the .github/workflows/stale.yml policy file label Dec 11, 2025
@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale Stale PRs per the .github/workflows/stale.yml policy file label Jan 25, 2026
@ramitkataria ramitkataria force-pushed the ramitkataria/providers-hook-async-conn branch from 68311e2 to b2319fd Compare January 26, 2026 18:30
@ramitkataria ramitkataria changed the title Use hook's native async conn getter in providers Use common provider's get_async_connection in other providers Jan 26, 2026
@ramitkataria
Copy link
Contributor Author

Are you still working on this? It was marked as stale and autoclosed

Yes, just rebased it using the common provider

@ramitkataria ramitkataria marked this pull request as ready for review January 26, 2026 19:49
Copy link
Contributor

@josh-fell josh-fell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL, nice.

@josh-fell josh-fell merged commit a90a1ac into apache:main Jan 26, 2026
136 of 155 checks passed
@ramitkataria ramitkataria deleted the ramitkataria/providers-hook-async-conn branch January 26, 2026 20:53
@dabla
Copy link
Contributor

dabla commented Jan 27, 2026

Nice work! Bit late for the review, but always make sure the common-compat version defined in providers is up-tot-date to use the required method as this is not always covered by the tests yet. @potiuk opened an issue for that.

shreyas-dev pushed a commit to shreyas-dev/airflow that referenced this pull request Jan 29, 2026
…#56791)

* Use common provider's get_async_connection in other providers

* Fix sftp and livy unit tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:providers provider:amazon AWS/Amazon - related issues provider:apache-livy provider:cncf-kubernetes Kubernetes (k8s) provider related issues provider:http provider:microsoft-azure Azure-related issues provider:pagerduty provider:sftp provider:slack stale Stale PRs per the .github/workflows/stale.yml policy file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants