[v3-1-test] Add triggering_user_name to DagRunProtocol interface (#56193) #56604
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
) * Add triggering_user_name to DagRunProtocol interface Enable tasks running in isolated environments to access the username that triggered a DAG run without requiring direct database access. Changes: - Add triggering_user_name field to DagRunProtocol interface - Update task-sdk DagRun data model to include triggering_user_name - Update execution API DagRun model to include triggering_user_name - Ensure field flows from database through API to task context This allows developers to identify DAG run triggers from within task code using the existing DagRunProtocol interface. * Fix tests! * Add Cadwyn migration for triggering_user_name field in DagRunProtocol Add backward compatibility migration for the new triggering_user_name field added to the DagRun model in the Execution API. This ensures older API clients continue to work seamlessly with newer API servers. * Add tests for older versions where triggering user is missing * Remove triggering user from v2025-04-28 * Add a test with triggering_user_name set (cherry picked from commit 3120146) Co-authored-by: Dheeraj Turaga <dheerajturaga@gmail.com>
Member
|
Not sure if we want to merge this one for 3.1.1 @kaxil @pierrejeambrun ? |
Member
|
Naah, I'll keep this for 3.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add triggering_user_name to DagRunProtocol interface
Enable tasks running in isolated environments to access the username
that triggered a DAG run without requiring direct database access.
Changes:
This allows developers to identify DAG run triggers from within task
code using the existing DagRunProtocol interface.
Fix tests!
Add Cadwyn migration for triggering_user_name field in DagRunProtocol
Add backward compatibility migration for the new triggering_user_name field
added to the DagRun model in the Execution API. This ensures older API
clients continue to work seamlessly with newer API servers.
Add tests for older versions where triggering user is missing
Remove triggering user from v2025-04-28
Add a test with triggering_user_name set
(cherry picked from commit 3120146)
Co-authored-by: Dheeraj Turaga dheerajturaga@gmail.com