-
Notifications
You must be signed in to change notification settings - Fork 16.4k
fix: scheduler, triggerer, worker airflow components have inconsistent log volume #56418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
jason810496
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Thanks for the PR.
It would be nice to update the helm-tests as well. Thanks!
|
@jason810496 Thanks for your suggestion. I've added helm-tests . |
|
Hi @rich7420, some tests are failing. Could you take a look? |
|
@Miretpl thanks for the reminding! I'll try to fix it up as soon as possible. |
Miretpl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thanks for the fix!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update!
It would be nice to test with breeze k8s command, thanks!
|
@jason810496 I've tried test with breeze k8s. |
|
Thanks @jscheffl , @jason810496 , @Miretpl ! |
…t log volume (apache#56418) * fix logs mount * helm test * fix error * try to fix error
related: #56015
How I Fixed It in this PRr
I added the missing logs volume mount to the
wait-for-airflow-migrationsinitContainers in these files:Test
Test 1: Reproduce the Original Problem
Grab this values file to mimic the issue:
Run this to check:
What you should see is all initContainers now have both the standard logs volume and any extra mounts—no more mismatches.
Test 2: With Persistence Enabled
Try this values file for persistent logs:
Check it out:
What you should see is InitContainers include the logs volume with the right
subPathconfig.Test 3: Just the Basics
No extra bells and whistles—test the default setup:
Run:
Then you should see Every initContainer has the standard logs volume mount, loud and clear.
Any Breaking Changes?
Nope, none at all.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.