Skip to content

Improve copy button usability on code blocks #56382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bbovenzi merged 1 commit into from
Oct 8, 2025
Merged

Improve copy button usability on code blocks #56382

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 29 additions & 16 deletions airflow-core/src/airflow/ui/src/pages/TaskInstance/RenderedTemplates.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
* specific language governing permissions and limitations
* under the License.
*/
import { Box, HStack, Table } from "@chakra-ui/react";
import { Box, Table } from "@chakra-ui/react";
import { useParams } from "react-router-dom";
import { PrismLight as SyntaxHighlighter } from "react-syntax-highlighter";
import bash from "react-syntax-highlighter/dist/esm/languages/prism/bash";
Expand Down Expand Up @@ -61,24 +61,37 @@ export const RenderedTemplates = () => {
<Table.Row key={key}>
<Table.Cell>{key}</Table.Cell>
<Table.Cell>
<HStack alignItems="flex-start">
<Box flex="1">
<Box as="pre" borderRadius="md" fontSize="sm" m={0} overflowX="auto" p={2}>
<SyntaxHighlighter
language={language}
PreTag="div" // Prevents double <pre> nesting
showLineNumbers
style={style}
wrapLongLines
>
{renderedValue}
</SyntaxHighlighter>
</Box>
<Box
css={{
"&:hover .copy-button": {
opacity: 1,
},
}}
>
<Box as="pre" borderRadius="md" fontSize="sm" m={0} overflowX="auto" p={2}>
<SyntaxHighlighter
language={language}
PreTag="div" // Prevents double <pre> nesting
showLineNumbers
style={style}
wrapLongLines
>
{renderedValue}
</SyntaxHighlighter>
</Box>
<ClipboardRoot value={renderedValue}>
<ClipboardRoot
className="copy-button"
float="right"
marginTop="-3.5rem"
opacity={0}
position="sticky"
right={4}
transition="opacity 0.2s ease-in-out"
value={renderedValue}
>
<ClipboardIconButton />
</ClipboardRoot>
</HStack>
</Box>
</Table.Cell>
</Table.Row>
);
Expand Down