Skip to content

AIP-67 - Multi Team: Pass args/kwargs to super in Celery executors #56006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eladkal merged 2 commits into from
Sep 23, 2025
Merged

AIP-67 - Multi Team: Pass args/kwargs to super in Celery executors #56006

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
94f9d08
pass args/kwargs to super in Celery executors
o-nikolas Sep 23, 2025
fae7bc1
Fix compat tests
o-nikolas Sep 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions providers/celery/src/airflow/providers/celery/executors/celery_executor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -290,8 +290,8 @@ class CeleryExecutor(BaseExecutor):
# TODO: TaskSDK: move this type change into BaseExecutor
queued_tasks: dict[TaskInstanceKey, workloads.All] # type: ignore[assignment]

def __init__(self):
super().__init__()
def __init__(self, *args, **kwargs):
super().__init__(*args, **kwargs)

# Celery doesn't support bulk sending the tasks (which can become a bottleneck on bigger clusters)
# so we use a multiprocessing pool to speed this up.
Expand Down
18 changes: 18 additions & 0 deletions providers/celery/tests/unit/celery/executors/test_celery_executor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,6 +126,24 @@ def test_supports_sentry(self):
def test_cli_commands_vended(self):
assert CeleryExecutor.get_cli_commands()

def test_celery_executor_init_with_args_kwargs(self):
"""Test that CeleryExecutor properly passes args and kwargs to BaseExecutor."""
parallelism = 50
team_name = "test_team"

if AIRFLOW_V_3_1_PLUS:
# team_name was added in Airflow 3.1
executor = celery_executor.CeleryExecutor(parallelism=parallelism, team_name=team_name)
else:
executor = celery_executor.CeleryExecutor(parallelism)

assert executor.parallelism == parallelism

if AIRFLOW_V_3_1_PLUS:
# team_name was added in Airflow 3.1
assert executor.team_name == team_name
assert executor.conf.team_name == team_name

@pytest.mark.backend("mysql", "postgres")
def test_exception_propagation(self, caplog):
caplog.set_level(
Expand Down