Only send hostname to celery worker if passed in cli #55913
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jedcunningham
force-pushed
the
fix_ce_click_compat
branch
from
a5e7bb1 to
9b24b6a
Compare
jedcunningham
added
the
full tests needed
kaxil
approved these changes
Sep 19, 2025
jedcunningham
removed
the
full tests needed
eladkal
approved these changes
Sep 23, 2025
kaxil
force-pushed
the
fix_ce_click_compat
branch
from
054baba to
f8fbce8
Compare
We were setting the hostname in the celery worker, even if the user did not specify one. This meant we were passing on None. Historically, that has still resulted in the default value being used instead of None, but that has changed in click 8.3.0 (which celery uses in its cli). Either way, no need for us to pass it!
It'll actually run when apache#55915 is merged, but it will pass when it does start running.
kaxil
force-pushed
the
fix_ce_click_compat
branch
from
f8fbce8 to
fa53f89
Compare
19 tasks
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Sep 30, 2025
* Only send hostname to celery worker if passed in cli We were setting the hostname in the celery worker, even if the user did not specify one. This meant we were passing on None. Historically, that has still resulted in the default value being used instead of None, but that has changed in click 8.3.0 (which celery uses in its cli). Either way, no need for us to pass it! * Fix test It'll actually run when apache#55915 is merged, but it will pass when it does start running.
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 1, 2025
* Only send hostname to celery worker if passed in cli We were setting the hostname in the celery worker, even if the user did not specify one. This meant we were passing on None. Historically, that has still resulted in the default value being used instead of None, but that has changed in click 8.3.0 (which celery uses in its cli). Either way, no need for us to pass it! * Fix test It'll actually run when apache#55915 is merged, but it will pass when it does start running.
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 2, 2025
* Only send hostname to celery worker if passed in cli We were setting the hostname in the celery worker, even if the user did not specify one. This meant we were passing on None. Historically, that has still resulted in the default value being used instead of None, but that has changed in click 8.3.0 (which celery uses in its cli). Either way, no need for us to pass it! * Fix test It'll actually run when apache#55915 is merged, but it will pass when it does start running.
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 3, 2025
* Only send hostname to celery worker if passed in cli We were setting the hostname in the celery worker, even if the user did not specify one. This meant we were passing on None. Historically, that has still resulted in the default value being used instead of None, but that has changed in click 8.3.0 (which celery uses in its cli). Either way, no need for us to pass it! * Fix test It'll actually run when apache#55915 is merged, but it will pass when it does start running.
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 4, 2025
* Only send hostname to celery worker if passed in cli We were setting the hostname in the celery worker, even if the user did not specify one. This meant we were passing on None. Historically, that has still resulted in the default value being used instead of None, but that has changed in click 8.3.0 (which celery uses in its cli). Either way, no need for us to pass it! * Fix test It'll actually run when apache#55915 is merged, but it will pass when it does start running.
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 5, 2025
* Only send hostname to celery worker if passed in cli We were setting the hostname in the celery worker, even if the user did not specify one. This meant we were passing on None. Historically, that has still resulted in the default value being used instead of None, but that has changed in click 8.3.0 (which celery uses in its cli). Either way, no need for us to pass it! * Fix test It'll actually run when apache#55915 is merged, but it will pass when it does start running.
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 5, 2025
* Only send hostname to celery worker if passed in cli We were setting the hostname in the celery worker, even if the user did not specify one. This meant we were passing on None. Historically, that has still resulted in the default value being used instead of None, but that has changed in click 8.3.0 (which celery uses in its cli). Either way, no need for us to pass it! * Fix test It'll actually run when apache#55915 is merged, but it will pass when it does start running.
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 7, 2025
* Only send hostname to celery worker if passed in cli We were setting the hostname in the celery worker, even if the user did not specify one. This meant we were passing on None. Historically, that has still resulted in the default value being used instead of None, but that has changed in click 8.3.0 (which celery uses in its cli). Either way, no need for us to pass it! * Fix test It'll actually run when apache#55915 is merged, but it will pass when it does start running.
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 8, 2025
* Only send hostname to celery worker if passed in cli We were setting the hostname in the celery worker, even if the user did not specify one. This meant we were passing on None. Historically, that has still resulted in the default value being used instead of None, but that has changed in click 8.3.0 (which celery uses in its cli). Either way, no need for us to pass it! * Fix test It'll actually run when apache#55915 is merged, but it will pass when it does start running.
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 9, 2025
* Only send hostname to celery worker if passed in cli We were setting the hostname in the celery worker, even if the user did not specify one. This meant we were passing on None. Historically, that has still resulted in the default value being used instead of None, but that has changed in click 8.3.0 (which celery uses in its cli). Either way, no need for us to pass it! * Fix test It'll actually run when apache#55915 is merged, but it will pass when it does start running.
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 10, 2025
* Only send hostname to celery worker if passed in cli We were setting the hostname in the celery worker, even if the user did not specify one. This meant we were passing on None. Historically, that has still resulted in the default value being used instead of None, but that has changed in click 8.3.0 (which celery uses in its cli). Either way, no need for us to pass it! * Fix test It'll actually run when apache#55915 is merged, but it will pass when it does start running.
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 11, 2025
* Only send hostname to celery worker if passed in cli We were setting the hostname in the celery worker, even if the user did not specify one. This meant we were passing on None. Historically, that has still resulted in the default value being used instead of None, but that has changed in click 8.3.0 (which celery uses in its cli). Either way, no need for us to pass it! * Fix test It'll actually run when apache#55915 is merged, but it will pass when it does start running.
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 12, 2025
* Only send hostname to celery worker if passed in cli We were setting the hostname in the celery worker, even if the user did not specify one. This meant we were passing on None. Historically, that has still resulted in the default value being used instead of None, but that has changed in click 8.3.0 (which celery uses in its cli). Either way, no need for us to pass it! * Fix test It'll actually run when apache#55915 is merged, but it will pass when it does start running.
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 14, 2025
* Only send hostname to celery worker if passed in cli We were setting the hostname in the celery worker, even if the user did not specify one. This meant we were passing on None. Historically, that has still resulted in the default value being used instead of None, but that has changed in click 8.3.0 (which celery uses in its cli). Either way, no need for us to pass it! * Fix test It'll actually run when apache#55915 is merged, but it will pass when it does start running.
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 15, 2025
* Only send hostname to celery worker if passed in cli We were setting the hostname in the celery worker, even if the user did not specify one. This meant we were passing on None. Historically, that has still resulted in the default value being used instead of None, but that has changed in click 8.3.0 (which celery uses in its cli). Either way, no need for us to pass it! * Fix test It'll actually run when apache#55915 is merged, but it will pass when it does start running.
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 17, 2025
* Only send hostname to celery worker if passed in cli We were setting the hostname in the celery worker, even if the user did not specify one. This meant we were passing on None. Historically, that has still resulted in the default value being used instead of None, but that has changed in click 8.3.0 (which celery uses in its cli). Either way, no need for us to pass it! * Fix test It'll actually run when apache#55915 is merged, but it will pass when it does start running.
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 19, 2025
* Only send hostname to celery worker if passed in cli We were setting the hostname in the celery worker, even if the user did not specify one. This meant we were passing on None. Historically, that has still resulted in the default value being used instead of None, but that has changed in click 8.3.0 (which celery uses in its cli). Either way, no need for us to pass it! * Fix test It'll actually run when apache#55915 is merged, but it will pass when it does start running.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were setting the hostname in the celery worker, even if the user did not specify one. This meant we were passing on None. Historically, that has still resulted in the default value being used instead of None, but that has changed in click 8.3.0 (which celery uses in its cli). Either way, no need for us to pass it!