[v3-0-test] Handle trigger calls to get_connection #55799 #55901
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dstandish
requested review from
Fokko,
XD-DENG,
amoghrajesh,
ashb,
bbovenzi,
bolkedebruin,
bugraoz93,
eladkal,
ephraimbuddy,
gopidesupavan,
hussein-awala,
jason810496,
jedcunningham,
josh-fell,
jscheffl,
kaxil,
mik-laj,
mobuchowski,
o-nikolas,
pierrejeambrun,
potiuk,
rawwar,
ryanahamilton,
shubhamraj-git,
uranusjr and
vincbeck
as code owners
In 2.x sometimes get_connection (which goes to the database) might be called without wrapping in sync_to_async. This did not fail, though it was not good behavior, since it can block the event loop. In 3.0, since we now route db calls through an API, triggers that do this fail. The reason is, the code to hit the API wraps the get_connection call with async_to_sync, which is forbidden in the asyncio event loop. Related: apache#55568 (cherry picked from commit f5b1eb4)
dstandish
force-pushed
the
backport-from-55799
branch
from
db63f72 to
805d7c2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 2.x sometimes get_connection (which goes to the database) might be called without wrapping in sync_to_async.
This did not fail, though it was not good behavior, since it can block the event loop.
In 3.0, since we now route db calls through an API, triggers that do this fail. The reason is, the code to hit the API wraps the get_connection call with async_to_sync, which is forbidden in the asyncio event loop.
Related: #55568
(cherry picked from commit f5b1eb4)
Works: