Skip to content

Conversation

@KatalKavya96
Copy link
Contributor

Switch Audit Logs to reusable FilterBar (parity with XCom)

This PR replaces the bespoke Audit Logs filters with the new reusable FilterBar component introduced in #54895. The change reduces vertical space, standardizes UX with XCom, and centralizes URL-sync logic.

What changed

  • Replace custom inputs with “pills” for:

  • User, Event Type, After, Before, Map Index, Try Number

  • DAG / Run / Task shown only when not fixed by the current route

  • Use pattern-style URL params (consistent with XCom):

  • dag_display_name_pattern → mapped to API dagIdPattern

  • run_id_pattern → runIdPattern

  • task_id_pattern → taskIdPattern

  • Keep all existing table behavior: sorting, pagination, and columns unchanged

  • No backend/API changes; only UI wiring and param mapping

Why

  • Pills save space and are easier to edit/reset

  • Aligns filtering UX across pages (XCom ↔ Audit Logs)

  • Centralizes filter state management via useFiltersHandler

How to test

  • Open Audit Logs (/events in your env).

Click + Filter to add pills; press Enter to apply.

Verify requests include the expected params:

owner_pattern, event_pattern, dates (after, before)

dag_id_pattern, run_id_pattern, task_id_pattern when applicable

Reset clears URL query and unfilters the table.

Navigate to DAG/Run/Task context pages — the corresponding pill disappears (context enforced by route).

Notes

  • No new i18n strings introduced (reuse existing keys/fallbacks).

  • Minimal footprint: only Audit Logs page touched.

  • Manual verification done on Breeze (Docker) against /api/v2/eventLogs.

#55520 - Audit Logs Only

@boring-cyborg boring-cyborg bot added the area:UI Related to UI/UX. For Frontend Developers. label Sep 14, 2025
@KatalKavya96 KatalKavya96 deleted the feat/ui-auditlogs-filterbar branch September 14, 2025 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:UI Related to UI/UX. For Frontend Developers.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant