Skip to content

Fix trigger job log tests #55563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
potiuk merged 3 commits into from
Sep 12, 2025
Merged

Fix trigger job log tests #55563

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3014447
Fix trigger log tests
gopidesupavan Sep 11, 2025
25cd196
Fix trigger job log test
gopidesupavan Sep 12, 2025
f8aa13d
Resolve comments
gopidesupavan Sep 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions airflow-core/tests/unit/jobs/test_triggerer_job.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,9 @@
clear_db_connections,
clear_db_dag_bundles,
clear_db_dags,
clear_db_jobs,
clear_db_runs,
clear_db_triggers,
clear_db_variables,
clear_db_xcom,
)
Expand All @@ -86,13 +88,17 @@ def clean_database():
clear_db_dag_bundles()
clear_db_xcom()
clear_db_variables()
clear_db_triggers()
clear_db_jobs()
yield # Test runs here
clear_db_connections()
clear_db_runs()
clear_db_dags()
clear_db_dag_bundles()
clear_db_xcom()
clear_db_variables()
clear_db_triggers()
clear_db_jobs()


def create_trigger_in_db(session, trigger, operator=None):
Expand Down Expand Up @@ -270,7 +276,10 @@ def send_msg_spy(self, msg, *args, **kwargs):

@pytest.mark.parametrize(
"trigger, watcher_count, trigger_count",
[(TimeDeltaTrigger(datetime.timedelta(days=7)), 0, 1), (FileDeleteTrigger("/tmp/foo.txt"), 1, 0)],
[
(TimeDeltaTrigger(datetime.timedelta(days=7)), 0, 1),
(FileDeleteTrigger("/tmp/foo.txt", poke_interval=1), 1, 0),
],
)
@patch("time.monotonic", side_effect=itertools.count(start=1, step=60))
def test_trigger_log(mock_monotonic, trigger, watcher_count, trigger_count, session, capsys):
Expand All @@ -279,10 +288,10 @@ def test_trigger_log(mock_monotonic, trigger, watcher_count, trigger_count, sess
"""
create_trigger_in_db(session, trigger)

trigger_runner_supervisor = TriggerRunnerSupervisor.start(job=Job(id=12345), capacity=10)
trigger_runner_supervisor = TriggerRunnerSupervisor.start(job=Job(id=123456), capacity=10)
trigger_runner_supervisor.load_triggers()

for _ in range(10):
for _ in range(30):
trigger_runner_supervisor._service_subprocess(0.1)

stdout = capsys.readouterr().out
Expand Down