Skip to content

Add react-dom to default plugin external libraries #55451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bbovenzi merged 1 commit into from
Sep 10, 2025
Merged

Add react-dom to default plugin external libraries #55451

bbovenzi merged 1 commit into from
Sep 10, 2025

Conversation

@pierrejeambrun
Copy link
Member

@pierrejeambrun pierrejeambrun commented Sep 10, 2025 •
edited
Loading

Follow up of: #55348

Adds react-dom to default external libraries when generating a react app plugin with the boostrapping tool.

Adding a modal is a fairly common use case and users shouldn't have to modify their vite config to achieve that.

@boring-cyborg boring-cyborg bot added area:dev-tools backport-to-v3-1-test Mark PR with this label to backport to v3-1-test branch labels Sep 10, 2025
@pierrejeambrun pierrejeambrun mentioned this pull request Sep 10, 2025
Merged
@pierrejeambrun
Copy link
Member Author

pierrejeambrun commented Sep 10, 2025

cc: @shubhamraj-git

@bbovenzi
Copy link
Contributor

bbovenzi commented Sep 10, 2025

Wait, adding a modal requires react-dom?

@jscheffl
Copy link
Contributor

jscheffl commented Sep 10, 2025

Wait, adding a modal requires react-dom?

It seems... unfortunately yes. Else the <Portal> is not working which is required for all pop-ups. Not sure why...
I also just realized that with the Toaster I implemented in Edge React UI this is also not working... it is not using portal but seems there is also a gap for plugins which I need to somebody helping me to know "why"

bbovenzi
bbovenzi approved these changes Sep 10, 2025
View reviewed changes
Copy link
Contributor

@bbovenzi bbovenzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't related to the Portal issues though. That needs to be explored more

@bbovenzi bbovenzi merged commit f80d308 into apache:main Sep 10, 2025
60 checks passed
@bbovenzi bbovenzi deleted the add-react-dom-to-default-globals-libraries branch September 10, 2025 15:52
@github-actions
Copy link

github-actions bot commented Sep 10, 2025

Backport failed to create: v3-0-test. View the failure log Run details

Status Branch Result
❌ v3-0-test Commit Link

You can attempt to backport this manually by running:

cherry_picker f80d308 v3-0-test

This should apply the commit to the v3-0-test branch and leave the commit in conflict state marking
the files that need manual conflict resolution.

After you have resolved the conflicts, you can continue the backport process by running:

cherry_picker --continue

@pierrejeambrun pierrejeambrun removed the backport-to-v3-1-test Mark PR with this label to backport to v3-1-test branch label Sep 10, 2025
@pierrejeambrun
Copy link
Member Author

pierrejeambrun commented Sep 10, 2025

No backport that's for 3.1.0

@jscheffl jscheffl added this to the Airflow 3.1.0 milestone Sep 10, 2025
@jscheffl jscheffl added the type:bug-fix Changelog: Bug Fixes label Sep 10, 2025
kaxil pushed a commit to astronomer/airflow that referenced this pull request Sep 11, 2025
@pierrejeambrun @kaxil
Add react-dom to default plugin external libraries (apache#55451)
4673170 
(cherry picked from commit f80d308)
suman-himanshu pushed a commit to suman-himanshu/airflow that referenced this pull request Sep 17, 2025
@pierrejeambrun @suman-himanshu
Add react-dom to default plugin external libraries (apache#55451)
5d79137
Brunda10 pushed a commit to Brunda10/airflow that referenced this pull request Sep 17, 2025
@pierrejeambrun @Brunda10
Add react-dom to default plugin external libraries (apache#55451)
65be530
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Sep 30, 2025
@pierrejeambrun
Add react-dom to default plugin external libraries (apache#55451)
b6e872e
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 1, 2025
@pierrejeambrun
Add react-dom to default plugin external libraries (apache#55451)
e4e3075
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 2, 2025
@pierrejeambrun
Add react-dom to default plugin external libraries (apache#55451)
90f3be8
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 3, 2025
@pierrejeambrun
Add react-dom to default plugin external libraries (apache#55451)
951f30f
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 4, 2025
@pierrejeambrun
Add react-dom to default plugin external libraries (apache#55451)
4861caf
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 5, 2025
@pierrejeambrun
Add react-dom to default plugin external libraries (apache#55451)
03709e2
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 5, 2025
@pierrejeambrun
Add react-dom to default plugin external libraries (apache#55451)
e355be8
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 7, 2025
@pierrejeambrun
Add react-dom to default plugin external libraries (apache#55451)
3d12401
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 8, 2025
@pierrejeambrun
Add react-dom to default plugin external libraries (apache#55451)
ec479ff
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 9, 2025
@pierrejeambrun
Add react-dom to default plugin external libraries (apache#55451)
5d0b342
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 10, 2025
@pierrejeambrun
Add react-dom to default plugin external libraries (apache#55451)
876c1f4
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 11, 2025
@pierrejeambrun
Add react-dom to default plugin external libraries (apache#55451)
4d475ad
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 12, 2025
@pierrejeambrun
Add react-dom to default plugin external libraries (apache#55451)
1579afb
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 14, 2025
@pierrejeambrun
Add react-dom to default plugin external libraries (apache#55451)
7e075f7
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 15, 2025
@pierrejeambrun
Add react-dom to default plugin external libraries (apache#55451)
60e8a6c
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 17, 2025
@pierrejeambrun
Add react-dom to default plugin external libraries (apache#55451)
4836282
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 19, 2025
@pierrejeambrun
Add react-dom to default plugin external libraries (apache#55451)
9723ee5
@potiuk potiuk mentioned this pull request Nov 8, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bbovenzi bbovenzi bbovenzi approved these changes

@jscheffl jscheffl jscheffl approved these changes

Assignees

No one assigned

Labels

area:dev-tools type:bug-fix Changelog: Bug Fixes

Projects

None yet

Milestone

Airflow 3.1.0

Development

Successfully merging this pull request may close these issues.

3 participants

@pierrejeambrun @bbovenzi @jscheffl