Include simple context in triggerer async callback #55241
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramitkataria
requested review from
XD-DENG,
amoghrajesh,
ashb and
kaxil
as code owners
boring-cyborg
bot
added
area:Scheduler
ramitkataria
force-pushed
the
ramitkataria/deadlines/context-in-callback
branch
from
0e5236e to
2c1e107
Compare
ashb
requested changes
Sep 4, 2025
Member
There was a problem hiding this comment.
Please find a way to do this does doesn't involve importing SDK inside DB models. We need to:
a) not add new uses of SDK inside Core (i.e. anything that runs in the scheduler or API servers etc)
b) We don't really want to render templates inside the scheduler, as that is dangerously close to running user code there.
ramitkataria
force-pushed
the
ramitkataria/deadlines/context-in-callback
branch
from
2c1e107 to
a34655d
Compare
Contributor
Author
|
Thanks for the pointers @ashb! I've made changes:
I've changed it to use the API data model
I've removed template rendering for this PR. After #55037, I wasn't sure how to run it in the triggerer but I'll explore that for a future PR |
ramitkataria
changed the title
ramitkataria
force-pushed
the
ramitkataria/deadlines/context-in-callback
branch
from
12c1545 to
7434448
Compare
ramitkataria
commented
Sep 4, 2025
ramitkataria
commented
Sep 4, 2025
ramitkataria
force-pushed
the
ramitkataria/deadlines/context-in-callback
branch
2 times, most recently
from
bd03481 to
9281e32
Compare
- Added a simple context dict in the kwargs - Set `context` as a reserved field for kwargs in callback definition Eventually, we should probably use the TaskSDK API in the triggerer to fetch the full context but this solution covers most use cases for now.
ramitkataria
force-pushed
the
ramitkataria/deadlines/context-in-callback
branch
from
9281e32 to
f109446
Compare
ferruzzi
approved these changes
Sep 5, 2025
Contributor
ferruzzi
left a comment
ferruzzi
left a comment
There was a problem hiding this comment.
Looks good for now. It'll be nice to get full context later but the dagrun has lots of useful info in it.
o-nikolas
approved these changes
Sep 5, 2025
Contributor
ashb
approved these changes
Sep 8, 2025
Member
ashb
left a comment
ashb
left a comment
There was a problem hiding this comment.
Few nits, but LGTM now, thanks for changing it
kaxil
reviewed
Sep 8, 2025
kaxil
approved these changes
Sep 8, 2025
Member
kaxil
left a comment
kaxil
left a comment
There was a problem hiding this comment.
Yeah, this is fine for now. We can improve this post 3.1
RoyLee1224
pushed a commit
to RoyLee1224/airflow
that referenced
this pull request
Sep 8, 2025
- Added a simple context dict in the kwargs - Set `context` as a reserved field for kwargs in callback definition Eventually, we should probably use the TaskSDK API in the triggerer to fetch the full context but this solution covers most use cases for now.
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Sep 30, 2025
- Added a simple context dict in the kwargs - Set `context` as a reserved field for kwargs in callback definition Eventually, we should probably use the TaskSDK API in the triggerer to fetch the full context but this solution covers most use cases for now.
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 1, 2025
- Added a simple context dict in the kwargs - Set `context` as a reserved field for kwargs in callback definition Eventually, we should probably use the TaskSDK API in the triggerer to fetch the full context but this solution covers most use cases for now.
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 2, 2025
- Added a simple context dict in the kwargs - Set `context` as a reserved field for kwargs in callback definition Eventually, we should probably use the TaskSDK API in the triggerer to fetch the full context but this solution covers most use cases for now.
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 3, 2025
- Added a simple context dict in the kwargs - Set `context` as a reserved field for kwargs in callback definition Eventually, we should probably use the TaskSDK API in the triggerer to fetch the full context but this solution covers most use cases for now.
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 4, 2025
- Added a simple context dict in the kwargs - Set `context` as a reserved field for kwargs in callback definition Eventually, we should probably use the TaskSDK API in the triggerer to fetch the full context but this solution covers most use cases for now.
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 5, 2025
- Added a simple context dict in the kwargs - Set `context` as a reserved field for kwargs in callback definition Eventually, we should probably use the TaskSDK API in the triggerer to fetch the full context but this solution covers most use cases for now.
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 5, 2025
- Added a simple context dict in the kwargs - Set `context` as a reserved field for kwargs in callback definition Eventually, we should probably use the TaskSDK API in the triggerer to fetch the full context but this solution covers most use cases for now.
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 7, 2025
- Added a simple context dict in the kwargs - Set `context` as a reserved field for kwargs in callback definition Eventually, we should probably use the TaskSDK API in the triggerer to fetch the full context but this solution covers most use cases for now.
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 8, 2025
- Added a simple context dict in the kwargs - Set `context` as a reserved field for kwargs in callback definition Eventually, we should probably use the TaskSDK API in the triggerer to fetch the full context but this solution covers most use cases for now.
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 9, 2025
- Added a simple context dict in the kwargs - Set `context` as a reserved field for kwargs in callback definition Eventually, we should probably use the TaskSDK API in the triggerer to fetch the full context but this solution covers most use cases for now.
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 10, 2025
- Added a simple context dict in the kwargs - Set `context` as a reserved field for kwargs in callback definition Eventually, we should probably use the TaskSDK API in the triggerer to fetch the full context but this solution covers most use cases for now.
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 11, 2025
- Added a simple context dict in the kwargs - Set `context` as a reserved field for kwargs in callback definition Eventually, we should probably use the TaskSDK API in the triggerer to fetch the full context but this solution covers most use cases for now.
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 12, 2025
- Added a simple context dict in the kwargs - Set `context` as a reserved field for kwargs in callback definition Eventually, we should probably use the TaskSDK API in the triggerer to fetch the full context but this solution covers most use cases for now.
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 14, 2025
- Added a simple context dict in the kwargs - Set `context` as a reserved field for kwargs in callback definition Eventually, we should probably use the TaskSDK API in the triggerer to fetch the full context but this solution covers most use cases for now.
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 15, 2025
- Added a simple context dict in the kwargs - Set `context` as a reserved field for kwargs in callback definition Eventually, we should probably use the TaskSDK API in the triggerer to fetch the full context but this solution covers most use cases for now.
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 17, 2025
- Added a simple context dict in the kwargs - Set `context` as a reserved field for kwargs in callback definition Eventually, we should probably use the TaskSDK API in the triggerer to fetch the full context but this solution covers most use cases for now.
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 19, 2025
- Added a simple context dict in the kwargs - Set `context` as a reserved field for kwargs in callback definition Eventually, we should probably use the TaskSDK API in the triggerer to fetch the full context but this solution covers most use cases for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added jinja template rendering for all kwargs being passed to deadline async callbackscontextas a reserved field for kwargs in callback definitionEventually, we should probably use the TaskSDK API in the triggerer to fetch the full context but this solution covers most use cases for now.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.