Alias task_display_name for EventLogResponse
#55160
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guan404ming
requested review from
XD-DENG,
ashb,
bbovenzi,
bugraoz93,
ephraimbuddy,
jason810496,
jscheffl,
kaxil,
pierrejeambrun,
potiuk,
rawwar,
ryanahamilton and
shubhamraj-git
as code owners
boring-cyborg
bot
added
area:airflow-ctl
area:API
guan404ming
force-pushed
the
alias-task-for-event-log
branch
from
660d08e to
5a2d4f4
Compare
uranusjr
reviewed
Sep 2, 2025
uranusjr
reviewed
Sep 2, 2025
guan404ming
force-pushed
the
alias-task-for-event-log
branch
2 times, most recently
from
09e7e2a to
3c90f03
Compare
pierrejeambrun
approved these changes
Sep 3, 2025
Member
pierrejeambrun
left a comment
pierrejeambrun
left a comment
There was a problem hiding this comment.
Looks good to me. We can merge once other comments are resolved.
Member
|
Feel free to resolve comments when they are address so we can merge it @guan404ming (unless there is more work planned here) |
Member
Author
Sure, let me resolve them. It's currently looks good for me but if TP still have any questions please feel free to let me know. I could help follow up or clarify. Thanks! |
guan404ming
force-pushed
the
alias-task-for-event-log
branch
2 times, most recently
from
7889406 to
c1dadfb
Compare
Member
There was a problem hiding this comment.
That makes me realize (I might be wrong) that we are not eagerly loading that relationship on the get_event_logs endpoint, which means that we are lazily emitting many request when serializing responses right?
We probably want to fix that by adding loading options? (I think we have the same issue for retrieving the dag_display_name, dagmodel will be joined lazyly)
guan404ming
force-pushed
the
alias-task-for-event-log
branch
from
4617540 to
ec87997
Compare
guan404ming
force-pushed
the
alias-task-for-event-log
branch
from
ec87997 to
81c45f5
Compare
pierrejeambrun
approved these changes
Sep 18, 2025
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Sep 30, 2025
* Alias task_display_name for event_logs * Update lazy loading to noload
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 1, 2025
* Alias task_display_name for event_logs * Update lazy loading to noload
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 2, 2025
* Alias task_display_name for event_logs * Update lazy loading to noload
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 3, 2025
* Alias task_display_name for event_logs * Update lazy loading to noload
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 4, 2025
* Alias task_display_name for event_logs * Update lazy loading to noload
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 5, 2025
* Alias task_display_name for event_logs * Update lazy loading to noload
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 5, 2025
* Alias task_display_name for event_logs * Update lazy loading to noload
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 7, 2025
* Alias task_display_name for event_logs * Update lazy loading to noload
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 8, 2025
* Alias task_display_name for event_logs * Update lazy loading to noload
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 9, 2025
* Alias task_display_name for event_logs * Update lazy loading to noload
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 10, 2025
* Alias task_display_name for event_logs * Update lazy loading to noload
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 11, 2025
* Alias task_display_name for event_logs * Update lazy loading to noload
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 12, 2025
* Alias task_display_name for event_logs * Update lazy loading to noload
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 14, 2025
* Alias task_display_name for event_logs * Update lazy loading to noload
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 15, 2025
* Alias task_display_name for event_logs * Update lazy loading to noload
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 17, 2025
* Alias task_display_name for event_logs * Update lazy loading to noload
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 19, 2025
* Alias task_display_name for event_logs * Update lazy loading to noload
pierrejeambrun
pushed a commit
to astronomer/airflow
that referenced
this pull request
Oct 31, 2025
* Alias task_display_name for event_logs * Update lazy loading to noload (cherry picked from commit 78b8b3c)
Member
|
Manual backport #57609 |
pierrejeambrun
added a commit
that referenced
this pull request
Oct 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
#46730
How
task_display_nameforEventLogResponse^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.