helm: statsd deployment volume mount without subpath for live reloading #54986
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaicoTimmerman
force-pushed
the
statsd-volume-mount-without-subpath
branch
4 times, most recently
from
a19e410 to
83085fd
Compare
MaicoTimmerman
requested review from
dstandish,
hussein-awala and
jedcunningham
as code owners
MaicoTimmerman
force-pushed
the
statsd-volume-mount-without-subpath
branch
from
83085fd to
93da6ed
Compare
MaicoTimmerman
force-pushed
the
statsd-volume-mount-without-subpath
branch
from
93da6ed to
b5de250
Compare
MaicoTimmerman
force-pushed
the
statsd-volume-mount-without-subpath
branch
from
b5de250 to
a9163d6
Compare
romsharon98
approved these changes
Sep 16, 2025
suman-himanshu
pushed a commit
to suman-himanshu/airflow
that referenced
this pull request
Sep 17, 2025
…ng (apache#54986) Co-authored-by: maico.timmerman@gmail.com <maico.timmerman@adyen.com>
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Sep 30, 2025
…ng (apache#54986) Co-authored-by: maico.timmerman@gmail.com <maico.timmerman@adyen.com>
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 1, 2025
…ng (apache#54986) Co-authored-by: maico.timmerman@gmail.com <maico.timmerman@adyen.com>
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 2, 2025
…ng (apache#54986) Co-authored-by: maico.timmerman@gmail.com <maico.timmerman@adyen.com>
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 3, 2025
…ng (apache#54986) Co-authored-by: maico.timmerman@gmail.com <maico.timmerman@adyen.com>
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 4, 2025
…ng (apache#54986) Co-authored-by: maico.timmerman@gmail.com <maico.timmerman@adyen.com>
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 5, 2025
…ng (apache#54986) Co-authored-by: maico.timmerman@gmail.com <maico.timmerman@adyen.com>
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 5, 2025
…ng (apache#54986) Co-authored-by: maico.timmerman@gmail.com <maico.timmerman@adyen.com>
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 7, 2025
…ng (apache#54986) Co-authored-by: maico.timmerman@gmail.com <maico.timmerman@adyen.com>
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 8, 2025
…ng (apache#54986) Co-authored-by: maico.timmerman@gmail.com <maico.timmerman@adyen.com>
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 9, 2025
…ng (apache#54986) Co-authored-by: maico.timmerman@gmail.com <maico.timmerman@adyen.com>
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 10, 2025
…ng (apache#54986) Co-authored-by: maico.timmerman@gmail.com <maico.timmerman@adyen.com>
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 11, 2025
…ng (apache#54986) Co-authored-by: maico.timmerman@gmail.com <maico.timmerman@adyen.com>
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 12, 2025
…ng (apache#54986) Co-authored-by: maico.timmerman@gmail.com <maico.timmerman@adyen.com>
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 14, 2025
…ng (apache#54986) Co-authored-by: maico.timmerman@gmail.com <maico.timmerman@adyen.com>
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 15, 2025
…ng (apache#54986) Co-authored-by: maico.timmerman@gmail.com <maico.timmerman@adyen.com>
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 17, 2025
…ng (apache#54986) Co-authored-by: maico.timmerman@gmail.com <maico.timmerman@adyen.com>
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 19, 2025
…ng (apache#54986) Co-authored-by: maico.timmerman@gmail.com <maico.timmerman@adyen.com>
96 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whenever the
statsd_exporter's mapping is changed, the deployment will need to restart. This loses some metrics. Thestatsd_exporterexposes a lifecycle API: https://github.com/prometheus/statsd_exporter?tab=readme-ov-file#lifecycle-api in order to reload the mapping.This is great, because we can reload mappings without losing metrics and downtime. However, quoting the Kubernetes documentation:
In this MR we resolve it, by mounting all files from the Statsd ConfigMap in the
/etc/statsd-exporter. This results in the same end result in the container filesystem, as it only contains a single file (mappings.yml).^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.