Skip to content

Conversation

@Crowiant
Copy link
Contributor

@Crowiant Crowiant commented Aug 27, 2025

During the work with CloudComposerRunAirflowCLICommandOperator I found out that the same error like in #53447 occurred with the operator in deferrable mode in local breeze environment. This error does not exist in AF2 only in AF3. After this fix works correctly in AF2 and AF3.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@boring-cyborg boring-cyborg bot added area:providers provider:google Google (including GCP) related issues labels Aug 27, 2025
@Crowiant Crowiant force-pushed the composer-async-hook-fix branch from cfef6ea to ede0163 Compare August 27, 2025 09:09
@potiuk
Copy link
Member

potiuk commented Aug 27, 2025

@VladaZakharova ?

@VladaZakharova
Copy link
Contributor

LGTM
Can you please add the description why we need these changes?

@Crowiant
Copy link
Contributor Author

Yes @VladaZakharova , I´ĺl add soon

Copy link
Contributor

@eladkal eladkal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please amend commit message to a meaningful one

@Crowiant Crowiant changed the title Fix CloudComposerAsyncHook to work correctly with af3. Change inheritance in CloudComposerAsyncHook from GoogleBaseHook to GoogleBaseAsyncHook. Sep 1, 2025
@Crowiant Crowiant changed the title Change inheritance in CloudComposerAsyncHook from GoogleBaseHook to GoogleBaseAsyncHook. Change CloudComposerAsyncHook to inherit from GoogleBaseAsyncHook instead of GoogleBaseHook. Sep 1, 2025
@Crowiant
Copy link
Contributor Author

Crowiant commented Sep 1, 2025

@eladkal done

@VladaZakharova
Copy link
Contributor

@eladkal Can you please check again? :)

@potiuk potiuk requested a review from eladkal September 4, 2025 12:37
@eladkal eladkal merged commit 866a1f0 into apache:main Sep 6, 2025
77 checks passed
mangal-vairalkar pushed a commit to mangal-vairalkar/airflow that referenced this pull request Sep 7, 2025
…54976)

Co-authored-by: Anton Nitochkin <nitochkin@google.com>
Co-authored-by: VladaZakharova <uladaz@google.com>
RoyLee1224 pushed a commit to RoyLee1224/airflow that referenced this pull request Sep 8, 2025
…54976)

Co-authored-by: Anton Nitochkin <nitochkin@google.com>
Co-authored-by: VladaZakharova <uladaz@google.com>
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Sep 30, 2025
…54976)

Co-authored-by: Anton Nitochkin <nitochkin@google.com>
Co-authored-by: VladaZakharova <uladaz@google.com>
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 1, 2025
…54976)

Co-authored-by: Anton Nitochkin <nitochkin@google.com>
Co-authored-by: VladaZakharova <uladaz@google.com>
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 2, 2025
…54976)

Co-authored-by: Anton Nitochkin <nitochkin@google.com>
Co-authored-by: VladaZakharova <uladaz@google.com>
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 3, 2025
…54976)

Co-authored-by: Anton Nitochkin <nitochkin@google.com>
Co-authored-by: VladaZakharova <uladaz@google.com>
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 4, 2025
…54976)

Co-authored-by: Anton Nitochkin <nitochkin@google.com>
Co-authored-by: VladaZakharova <uladaz@google.com>
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 5, 2025
…54976)

Co-authored-by: Anton Nitochkin <nitochkin@google.com>
Co-authored-by: VladaZakharova <uladaz@google.com>
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 5, 2025
…54976)

Co-authored-by: Anton Nitochkin <nitochkin@google.com>
Co-authored-by: VladaZakharova <uladaz@google.com>
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 7, 2025
…54976)

Co-authored-by: Anton Nitochkin <nitochkin@google.com>
Co-authored-by: VladaZakharova <uladaz@google.com>
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 8, 2025
…54976)

Co-authored-by: Anton Nitochkin <nitochkin@google.com>
Co-authored-by: VladaZakharova <uladaz@google.com>
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 9, 2025
…54976)

Co-authored-by: Anton Nitochkin <nitochkin@google.com>
Co-authored-by: VladaZakharova <uladaz@google.com>
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 10, 2025
…54976)

Co-authored-by: Anton Nitochkin <nitochkin@google.com>
Co-authored-by: VladaZakharova <uladaz@google.com>
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 11, 2025
…54976)

Co-authored-by: Anton Nitochkin <nitochkin@google.com>
Co-authored-by: VladaZakharova <uladaz@google.com>
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 12, 2025
…54976)

Co-authored-by: Anton Nitochkin <nitochkin@google.com>
Co-authored-by: VladaZakharova <uladaz@google.com>
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 14, 2025
…54976)

Co-authored-by: Anton Nitochkin <nitochkin@google.com>
Co-authored-by: VladaZakharova <uladaz@google.com>
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 15, 2025
…54976)

Co-authored-by: Anton Nitochkin <nitochkin@google.com>
Co-authored-by: VladaZakharova <uladaz@google.com>
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 17, 2025
…54976)

Co-authored-by: Anton Nitochkin <nitochkin@google.com>
Co-authored-by: VladaZakharova <uladaz@google.com>
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 19, 2025
…54976)

Co-authored-by: Anton Nitochkin <nitochkin@google.com>
Co-authored-by: VladaZakharova <uladaz@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:providers provider:google Google (including GCP) related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants