Fix XCom include_prior_dates API versioning coverage
#54810
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extend `AddIncludePriorDatesToGetXComSlice` version change to include
`GetXcomFilterParams` in addition to `GetXComSliceFilterParams`.
This ensures that the include_prior_dates field is properly handled
in API version migrations for both XCom endpoints:
- GET /xcoms/{dag_id}/{run_id}/{task_id}/{key} (single XCom)
- GET /xcoms/{dag_id}/{run_id}/{task_id}/{key}/slice (XCom slice)
This was missed in apache#53809
github-project-automation
bot
moved this to Done
in AIP-72 - Task Execution Interface and SDK
mangal-vairalkar
pushed a commit
to mangal-vairalkar/airflow
that referenced
this pull request
Aug 30, 2025
Extend `AddIncludePriorDatesToGetXComSlice` version change to include
`GetXcomFilterParams` in addition to `GetXComSliceFilterParams`.
This ensures that the include_prior_dates field is properly handled
in API version migrations for both XCom endpoints:
- GET /xcoms/{dag_id}/{run_id}/{task_id}/{key} (single XCom)
- GET /xcoms/{dag_id}/{run_id}/{task_id}/{key}/slice (XCom slice)
This was missed in apache#53809
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extend
AddIncludePriorDatesToGetXComSliceversion change to includeGetXcomFilterParamsin addition toGetXComSliceFilterParams.This ensures that the include_prior_dates field is properly handled in API version migrations for both XCom endpoints:
This was missed in #53809
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.