Allow setting restartPolicy for batch jobs in chart #54354
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ihorlukianov
requested review from
dstandish,
hussein-awala and
jedcunningham
as code owners
Member
|
Would it be possible to add helm tests for it ? |
Contributor
Author
|
@potiuk, added UTs covering this change. Thanks! |
potiuk
approved these changes
Aug 21, 2025
Member
|
Nice! thanks for being responsive ! |
mangal-vairalkar
pushed a commit
to mangal-vairalkar/airflow
that referenced
this pull request
Aug 30, 2025
* Allow setting restartPolicy for batch jobs in chart * fix static checks * Added UTs
96 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This PR introduces an option to configure the
restartPolicyfor batch jobs, allowing it to be set toNeverinstead of the current hardcodedOnFailure.Problem:
Currently, the
restartPolicyfor batch jobs is hardcoded toOnFailure. In deployments that use sidecar containers (e.g., Istio), this can lead to issues. When the main container fails and restarts, the sidecar may be prematurely terminated by a wrapper (likescuttle), affecting subsequent attempts. This means the job cannot recover properly on its own.Solution:
This change allows users to configure the
restartPolicytoNever. When set toNever, a failed job will trigger a new pod instead of just restarting the container within the same pod. This ensures that a fresh, uncompromised environment is created for each retry, resolving the sidecar termination issue and enabling proper job recovery.Impact:
This change provides greater flexibility for users with complex deployment configurations, particularly those relying on service meshes or other sidecar patterns. The new configuration option is opt-in, so existing deployments will not be affected unless they explicitly configure the new policy.