Skip to content

Conversation

@potiuk
Copy link
Member

@potiuk potiuk commented Aug 5, 2025

The #51774 changed the important way how intialization is done, it was causing circular imports in case it was imported directly.

This PR changes minimum version of common messaging for all providers using it and generally for core airflow.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

Copy link
Member

@jason810496 jason810496 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

The apache#51774 changed the important way how intialization is done,
it was causing circular imports in case it was imported directly.

This PR changes minimum version of common messaging for all providers
using it and generally for core airflow.
@potiuk potiuk force-pushed the update-min-version-of-common-messaging branch from 3e05495 to 06a7741 Compare August 6, 2025 08:38
@potiuk
Copy link
Member Author

potiuk commented Aug 6, 2025

The mypy us because of types-paramiko that removes DSS

@potiuk potiuk merged commit 9cc0717 into apache:main Aug 6, 2025
175 of 176 checks passed
@potiuk potiuk deleted the update-min-version-of-common-messaging branch August 6, 2025 09:14
@github-actions
Copy link

github-actions bot commented Aug 6, 2025

Backport failed to create: v3-0-test. View the failure log Run details

Status Branch Result
v3-0-test Commit Link

You can attempt to backport this manually by running:

cherry_picker 9cc0717 v3-0-test

This should apply the commit to the v3-0-test branch and leave the commit in conflict state marking
the files that need manual conflict resolution.

After you have resolved the conflicts, you can continue the backport process by running:

cherry_picker --continue

potiuk added a commit to potiuk/airflow that referenced this pull request Aug 6, 2025
The apache#51774 changed the important way how intialization is done,
it was causing circular imports in case it was imported directly.

This PR changes minimum version of common messaging for all providers
using it and generally for core airflow.

(cherry picked from commit 9cc0717)
potiuk added a commit that referenced this pull request Aug 6, 2025
The #51774 changed the important way how intialization is done,
it was causing circular imports in case it was imported directly.

This PR changes minimum version of common messaging for all providers
using it and generally for core airflow.

(cherry picked from commit 9cc0717)
ashb pushed a commit that referenced this pull request Aug 6, 2025
The #51774 changed the important way how intialization is done,
it was causing circular imports in case it was imported directly.

This PR changes minimum version of common messaging for all providers
using it and generally for core airflow.

(cherry picked from commit 9cc0717)
ferruzzi pushed a commit to aws-mwaa/upstream-to-airflow that referenced this pull request Aug 7, 2025
The apache#51774 changed the important way how intialization is done,
it was causing circular imports in case it was imported directly.

This PR changes minimum version of common messaging for all providers
using it and generally for core airflow.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:dev-tools area:providers backport-to-v3-1-test Mark PR with this label to backport to v3-1-test branch provider:amazon AWS/Amazon - related issues provider:apache-kafka

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants