Skip to content

Conversation

@amoghrajesh
Copy link
Contributor

======================================================================================== short test summary info =========================================================================================
FAILED providers/apache/flink/tests/unit/apache/flink/sensors/test_flink_kubernetes.py::TestFlinkKubernetesSensor::test_driver_logging_completed - assert equals failed
  'Flink application ended successfully'                                                        "2022-09-25 19:01:47,027 INFO  KubernetesTaskExecutorRunner [] - ---------\nSuccessful regis 
                                                                                                tration at resource manager akka.tcp://flink@basic-example.default:6\nReceive slot request 8 
                                                                                                0a7ef3e8cc1a2c09b4e3b2fbd70b28d for job 363eed78e59\nCheckpoint storage is set to 'jobmanage 
                                                                                                r'\nFlat Map -> Sink: Print to Std. Out (2/2)#0 (e7492dc4a) switched to RUNNING."
============================================================ 1 failed, 13193 passed, 3707 skipped, 1 xfailed, 5 warnings in 630.90s (0:10:30) ============================================================

related to #53743


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@potiuk
Copy link
Member

potiuk commented Jul 25, 2025

Nice... Was about to look at this one :)

@potiuk potiuk merged commit e9ed4e1 into apache:main Jul 25, 2025
73 checks passed
@kyungjunleeme
Copy link
Contributor

This kind of code style is one of the strengths of writing tests with pytest — just like we discussed in the thread.

@amoghrajesh amoghrajesh requested a review from eladkal July 25, 2025 09:57
@amoghrajesh
Copy link
Contributor Author

Precisely, I used the suggestions we had in the email thread and it worked well!

@potiuk
Copy link
Member

potiuk commented Jul 25, 2025

Yep - very nice :)

ferruzzi pushed a commit to aws-mwaa/upstream-to-airflow that referenced this pull request Aug 7, 2025
fweilun pushed a commit to fweilun/airflow that referenced this pull request Aug 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants