Skip to content

Making some brittle tests related to log assertion more robust #53743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
amoghrajesh merged 1 commit into from
Jul 25, 2025
Merged

Making some brittle tests related to log assertion more robust #53743

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 3 additions & 7 deletions providers/cncf/kubernetes/tests/unit/cncf/kubernetes/sensors/test_spark_kubernetes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
from __future__ import annotations

import json
from unittest.mock import patch
from unittest.mock import call, patch

import pytest
from kubernetes.client.rest import ApiException
Expand Down Expand Up @@ -841,9 +841,7 @@ def test_driver_logging_completed(
mock_log_call.assert_called_once_with(
"spark-pi-2020-02-24-1-driver", namespace="default", container="spark-kubernetes-driver"
)
log_info_call = info_log_call.mock_calls[2]
log_value = log_info_call[1][0]
assert log_value == TEST_POD_LOG_RESULT
assert call(TEST_POD_LOG_RESULT) in info_log_call.mock_calls

@patch(
"kubernetes.client.api.custom_objects_api.CustomObjectsApi.get_namespaced_custom_object",
Expand Down Expand Up @@ -888,6 +886,4 @@ def test_sidecar_driver_logging_completed(
mock_log_call.assert_called_once_with(
"spark-pi-2020-02-24-1-driver", namespace="default", container="spark-kubernetes-driver"
)
log_info_call = info_log_call.mock_calls[2]
log_value = log_info_call[1][0]
assert log_value == TEST_POD_LOG_RESULT
assert call(TEST_POD_LOG_RESULT) in info_log_call.mock_calls