Fix key error in _handle_execution_date_fn for ExternalTaskSensor #53728
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on_date_fn context - Try context['logical_date'], then context['execution_date'], then dag_run.run_after - Prevents KeyError when users run in environments without 'logical_date' Closes apache#52236 fix(external_task_sensor): fallback to execution_date key for execution_date_fn context - Try context['logical_date'], then context['execution_date'], then dag_run.run_after - Prevents KeyError when users run in environments without 'logical_date' Closes apache#52236
…m/yeswanth-bf/airflow into fix-52236-execution-date-fallback
Signed-off-by: yeswanth-bf <117461015+yeswanth-bf@users.noreply.github.com>
Member
Author
|
cc: @yeswanth-s1th |
shahar1
approved these changes
Jul 26, 2025
ferruzzi
pushed a commit
to aws-mwaa/upstream-to-airflow
that referenced
this pull request
Aug 7, 2025
…ache#53728) * fix(external_task_sensor): fallback to execution_date key for execution_date_fn context - Try context['logical_date'], then context['execution_date'], then dag_run.run_after - Prevents KeyError when users run in environments without 'logical_date' Closes apache#52236 fix(external_task_sensor): fallback to execution_date key for execution_date_fn context - Try context['logical_date'], then context['execution_date'], then dag_run.run_after - Prevents KeyError when users run in environments without 'logical_date' Closes apache#52236 * test: alias stdlib datetime to dt to avoid shadowing timezone datetime * chore: apply blank-line fix to docstring and add logical_date tests Signed-off-by: yeswanth-bf <117461015+yeswanth-bf@users.noreply.github.com> * Update external_task.py * Fix key error in _handle_execution_date_fn for ExternalTaskSensor * Fix tests --------- Signed-off-by: yeswanth-bf <117461015+yeswanth-bf@users.noreply.github.com> Co-authored-by: yeswanth-bf <117461015+yeswanth-bf@users.noreply.github.com> Co-authored-by: Yeswanth Surampudi <117461015+yeswanth-s1th@users.noreply.github.com>
fweilun
pushed a commit
to fweilun/airflow
that referenced
this pull request
Aug 11, 2025
…ache#53728) * fix(external_task_sensor): fallback to execution_date key for execution_date_fn context - Try context['logical_date'], then context['execution_date'], then dag_run.run_after - Prevents KeyError when users run in environments without 'logical_date' Closes apache#52236 fix(external_task_sensor): fallback to execution_date key for execution_date_fn context - Try context['logical_date'], then context['execution_date'], then dag_run.run_after - Prevents KeyError when users run in environments without 'logical_date' Closes apache#52236 * test: alias stdlib datetime to dt to avoid shadowing timezone datetime * chore: apply blank-line fix to docstring and add logical_date tests Signed-off-by: yeswanth-bf <117461015+yeswanth-bf@users.noreply.github.com> * Update external_task.py * Fix key error in _handle_execution_date_fn for ExternalTaskSensor * Fix tests --------- Signed-off-by: yeswanth-bf <117461015+yeswanth-bf@users.noreply.github.com> Co-authored-by: yeswanth-bf <117461015+yeswanth-bf@users.noreply.github.com> Co-authored-by: Yeswanth Surampudi <117461015+yeswanth-s1th@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #52236
closes #52236
cherry-picked changes from #52431
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.