Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion airflow-core/src/airflow/utils/log/logging_mixin.py
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ def _set_context(self, context):
set_context(self.log, context)


class ExternalLoggingMixin:
class ExternalLoggingMixin(metaclass=abc.ABCMeta):
"""Define a log handler based on an external service (e.g. ELK, StackDriver)."""

@property
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -209,9 +209,11 @@ def set_context(self, ti: TaskInstance, *, identifier: str | None = None) -> Non
extras={
"dag_id": str(ti.dag_id),
"task_id": str(ti.task_id),
date_key: self._clean_date(ti.logical_date)
if AIRFLOW_V_3_0_PLUS
else self._clean_date(ti.execution_date),
date_key: (
self._clean_date(ti.logical_date)
if AIRFLOW_V_3_0_PLUS
else self._clean_date(ti.execution_date)
),
"try_number": str(ti.try_number),
"log_id": self._render_log_id(ti, ti.try_number),
},
Expand Down Expand Up @@ -597,3 +599,25 @@ def _format_msg(self, hit: Hit):

# Just a safe-guard to preserve backwards-compatibility
return hit.message

@property
def supports_external_link(self) -> bool:
"""
Whether we can support external links.

TODO: It should support frontend just like ElasticSearchTaskhandler.
"""
return False

def get_external_log_url(self, task_instance, try_number) -> str:
"""
Create an address for an external log collecting service.

TODO: It should support frontend just like ElasticSearchTaskhandler.
"""
return ""

@property
def log_name(self) -> str:
"""The log name."""
return self.LOG_NAME