Fix DataprocClusterTrigger by passing objects in correct types so that they can be serialized #53485
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
provider:google
potiuk
approved these changes
Jul 19, 2025
Member
|
Nice! |
Member
|
Conflicts need to be resolved though. |
# Conflicts: # providers/google/tests/unit/google/cloud/triggers/test_dataproc.py
VladaZakharova
force-pushed
the
dataproc-bug
branch
from
e601e1d to
3c0be86
Compare
potiuk
approved these changes
Jul 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case if the Dataproc cluster was not created successfully the trigger should yield the event with cluster object and cluster_state.
The problem is that from the triggerer we return values that can't be serialized correctly - the whole Cluster object and cluster status in Enum format. It caused crash on triggerer it during execution and endlessly running task. I have fixed this behavior by passing Cluster object as dict and cluster state in string format.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.