-
Notifications
You must be signed in to change notification settings - Fork 16.4k
Add react apps plugins to the UI #53377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
jscheffl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks very cool!
Would need the upcoming weekend to be able to create my own test plugin to validate. So approval is based on reading only.
pierrejeambrun
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super cool!
Just a few minor suggestions, but nothing blocking IMO
Dynamically render react_apps plugins in the nav bar and in dag/run/task tabs just like iframe plugins.
Next up, adding react plugins into the dashboard
Closes #42702
Example of a plugin added to a mapped task instance with dagId, taskId, mapIndex and runId being passed as component props:

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.