Skip to content

Cleanup mypy ignore for fab provider in init_jinja_globals #53328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gopidesupavan merged 1 commit into from
Jul 14, 2025
Merged

Cleanup mypy ignore for fab provider in init_jinja_globals #53328

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions providers/fab/src/airflow/providers/fab/www/extensions/init_jinja_globals.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@

import logging

import pendulum
from pendulum import local_timezone

import airflow
from airflow.api_fastapi.app import get_auth_manager
Expand All @@ -33,7 +33,10 @@ def init_jinja_globals(app, enable_plugins: bool):
"""Add extra globals variable to Jinja context."""
server_timezone = conf.get("core", "default_timezone")
if server_timezone == "system":
server_timezone = pendulum.local_timezone().name # type: ignore[operator]
if callable(local_timezone):
server_timezone = local_timezone().name
else:
raise ValueError("`local_timezone` is not callable")
elif server_timezone == "utc":
server_timezone = "UTC"

Expand Down
2 changes: 1 addition & 1 deletion providers/fab/www-hash.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
06230f1bd1b77ee1be84feaaa61b26d7dcdb2f4665ec619e459b7d8b383f3ca0
e69fa4a826fffc13af6cbb7e0f99ec2945ab48e529a48cd59a4d8ace30380ce1