Skip to content

Cleanup mypy ignore in fab provider where possible #53282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gopidesupavan merged 3 commits into from
Jul 12, 2025
Merged

Cleanup mypy ignore in fab provider where possible #53282

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f4f9064
Cleanup mypy ignore in fab provider where possible
gopidesupavan Jul 12, 2025
ebdda38
Revert "Cleanup mypy ignore in fab provider where possible"
gopidesupavan Jul 12, 2025
e215310
Cleanup mypy ignore in fab provider where possible
gopidesupavan Jul 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion providers/fab/tests/unit/fab/auth_manager/api_endpoints/test_role_and_permission_endpoint.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ class TestRoleEndpoint:
@pytest.fixture(autouse=True)
def setup_attrs(self, configured_app) -> None:
self.app = configured_app
self.client = self.app.test_client() # type:ignore
self.client = self.app.test_client()

def teardown_method(self):
"""
Expand Down
2 changes: 1 addition & 1 deletion providers/fab/tests/unit/fab/auth_manager/api_endpoints/test_user_endpoint.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ class TestUserEndpoint:
@pytest.fixture(autouse=True)
def setup_attrs(self, configured_app) -> None:
self.app = configured_app
self.client = self.app.test_client() # type:ignore
self.client = self.app.test_client()
self.session = self.app.appbuilder.get_session

def teardown_method(self) -> None:
Expand Down
6 changes: 3 additions & 3 deletions providers/fab/tests/unit/fab/auth_manager/schemas/test_role_and_permission_schema.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ class TestRoleCollectionItemSchema:
@pytest.fixture(scope="class")
def role(self, minimal_app_for_auth_api):
yield create_role(
minimal_app_for_auth_api, # type: ignore
minimal_app_for_auth_api,
name="Test",
permissions=[
(permissions.ACTION_CAN_CREATE, permissions.RESOURCE_CONNECTION),
Expand Down Expand Up @@ -70,7 +70,7 @@ class TestRoleCollectionSchema:
@pytest.fixture(scope="class")
def role1(self, minimal_app_for_auth_api):
yield create_role(
minimal_app_for_auth_api, # type: ignore
minimal_app_for_auth_api,
name="Test1",
permissions=[
(permissions.ACTION_CAN_CREATE, permissions.RESOURCE_CONNECTION),
Expand All @@ -81,7 +81,7 @@ def role1(self, minimal_app_for_auth_api):
@pytest.fixture(scope="class")
def role2(self, minimal_app_for_auth_api):
yield create_role(
minimal_app_for_auth_api, # type: ignore
minimal_app_for_auth_api,
name="Test2",
permissions=[
(permissions.ACTION_CAN_EDIT, permissions.RESOURCE_DAG),
Expand Down
4 changes: 2 additions & 2 deletions providers/fab/tests/unit/fab/auth_manager/schemas/test_user_schema.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,14 +48,14 @@ def configured_app(minimal_app_for_auth_api):
)
yield app

delete_role(app, "TestRole") # type:ignore
delete_role(app, "TestRole")


class TestUserBase:
@pytest.fixture(autouse=True)
def setup_attrs(self, configured_app) -> None:
self.app = configured_app
self.client = self.app.test_client() # type:ignore
self.client = self.app.test_client()
self.role = self.app.appbuilder.sm.find_role("TestRole")
self.session = self.app.appbuilder.get_session

Expand Down
8 changes: 2 additions & 6 deletions providers/fab/tests/unit/fab/auth_manager/test_security.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -524,9 +524,7 @@ def test_get_accessible_dag_ids(mock_is_logged_in, app, security_manager, sessio
session.add(dag_model)
session.commit()

security_manager.sync_perm_for_dag( # type: ignore
dag_id, access_control={role_name: permission_action}
)
security_manager.sync_perm_for_dag(dag_id, access_control={role_name: permission_action})

assert get_auth_manager().get_authorized_dag_ids(user=user) == {"dag_id"}

Expand Down Expand Up @@ -558,9 +556,7 @@ def test_dont_get_inaccessible_dag_ids_for_dag_resource_permission(
session.add(dag_model)
session.commit()

security_manager.sync_perm_for_dag( # type: ignore
dag_id, access_control={role_name: permission_action}
)
security_manager.sync_perm_for_dag(dag_id, access_control={role_name: permission_action})

assert get_auth_manager().get_authorized_dag_ids(user=user) == set()

Expand Down
4 changes: 2 additions & 2 deletions providers/fab/tests/unit/fab/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,11 +242,11 @@ def manager() -> Generator[list[_TemplateWithContext], None, None]:
def record(sender, template, context, **extra):
recorded.append(_TemplateWithContext(template, context))

flask.template_rendered.connect(record, app) # type: ignore
flask.template_rendered.connect(record, app)
try:
yield recorded
finally:
flask.template_rendered.disconnect(record, app) # type: ignore
flask.template_rendered.disconnect(record, app)

assert recorded, "Failed to catch the templates"

Expand Down
2 changes: 1 addition & 1 deletion providers/fab/tests/unit/fab/www/views/test_views_custom_user_views.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ def setup_method(self):
self.delete_roles()
self.db = SQLA(self.app)

self.client = self.app.test_client() # type:ignore
self.client = self.app.test_client()

def teardown_method(self):
delete_user(self.app, "no_access")
Expand Down