Skip to content

Cleanup type ignores in trino provider where possible #53253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jscheffl merged 2 commits into from
Jul 13, 2025
Merged

Cleanup type ignores in trino provider where possible #53253

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
93e31d9
Cleanup type ignores in trino provider where possible
jscheffl Jul 12, 2025
43ffab8
Get the hook the right way via get_conn_id()
jscheffl Jul 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions providers/trino/src/airflow/providers/trino/hooks/trino.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,14 +146,14 @@ def __init__(self, *args, **kwargs):

def get_conn(self) -> Connection:
"""Return a connection object."""
db = self.get_connection(self.trino_conn_id) # type: ignore[attr-defined]
db = self.get_connection(self.get_conn_id())
extra = db.extra_dejson
auth = None
user = db.login
if db.password and extra.get("auth") in ("kerberos", "certs"):
raise AirflowException(f"The {extra.get('auth')!r} authorization type doesn't support password.")
if db.password:
auth = trino.auth.BasicAuthentication(db.login, db.password) # type: ignore[attr-defined]
auth = trino.auth.BasicAuthentication(db.login, db.password)
elif extra.get("auth") == "jwt":
if not exactly_one(jwt_file := "jwt__file" in extra, jwt_token := "jwt__token" in extra):
msg = (
Expand All @@ -176,7 +176,7 @@ def get_conn(self) -> Connection:
extra.get("certs__client_key_path"),
)
elif extra.get("auth") == "kerberos":
auth = trino.auth.KerberosAuthentication( # type: ignore[attr-defined]
auth = trino.auth.KerberosAuthentication(
config=extra.get("kerberos__config", os.environ.get("KRB5_CONFIG")),
service_name=extra.get("kerberos__service_name"),
mutual_authentication=_boolify(extra.get("kerberos__mutual_authentication", False)),
Expand Down Expand Up @@ -205,7 +205,6 @@ def get_conn(self) -> Connection:
catalog=extra.get("catalog", "hive"),
schema=db.schema,
auth=auth,
# type: ignore[func-returns-value]
isolation_level=self.get_isolation_level(),
verify=_boolify(extra.get("verify", True)),
session_properties=extra.get("session_properties") or None,
Expand All @@ -219,7 +218,7 @@ def get_conn(self) -> Connection:

def get_isolation_level(self) -> Any:
"""Return an isolation level."""
db = self.get_connection(self.trino_conn_id) # type: ignore[attr-defined]
db = self.get_connection(self.get_conn_id())
isolation_level = db.extra_dejson.get("isolation_level", "AUTOCOMMIT").upper()
return getattr(IsolationLevel, isolation_level, IsolationLevel.AUTOCOMMIT)

Expand Down