Skip to content

[v3-0-test] Dont use builtin len as varibale (#51992) #53193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ashb merged 1 commit into from
Jul 11, 2025
Merged

[v3-0-test] Dont use builtin len as varibale (#51992) #53193

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions airflow-core/src/airflow/jobs/triggerer_job_runner.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -714,11 +714,11 @@ def send(self, msg: ToTriggerSupervisor) -> ToTriggerRunner | None:

async def _aread_frame(self):
len_bytes = await self._async_reader.readexactly(4)
len = int.from_bytes(len_bytes, byteorder="big")
if len >= 2**32:
raise OverflowError(f"Refusing to receive messages larger than 4GiB {len=}")
length = int.from_bytes(len_bytes, byteorder="big")
if length >= 2**32:
raise OverflowError(f"Refusing to receive messages larger than 4GiB {length=}")

buffer = await self._async_reader.readexactly(len)
buffer = await self._async_reader.readexactly(length)
return self.resp_decoder.decode(buffer)

async def _aget_response(self, expect_id: int) -> ToTriggerRunner | None:
Expand Down
12 changes: 6 additions & 6 deletions task-sdk/src/airflow/sdk/execution_time/comms.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,9 +183,9 @@ class CommsDecoder(Generic[ReceiveMsgType, SendMsgType]):
def send(self, msg: SendMsgType) -> ReceiveMsgType | None:
"""Send a request to the parent and block until the response is received."""
frame = _RequestFrame(id=next(self.id_counter), body=msg.model_dump())
bytes = frame.as_bytes()
frame_bytes = frame.as_bytes()

self.socket.sendall(bytes)
self.socket.sendall(frame_bytes)
if isinstance(msg, ResendLoggingFD):
if recv_fds is None:
return None
Expand Down Expand Up @@ -225,13 +225,13 @@ def _read_frame(self, maxfds: int | None = None) -> tuple[_ResponseFrame, list[i
if len_bytes == b"":
raise EOFError("Request socket closed before length")

len = int.from_bytes(len_bytes, byteorder="big")
length = int.from_bytes(len_bytes, byteorder="big")

buffer = bytearray(len)
buffer = bytearray(length)
nread = self.socket.recv_into(buffer)
if nread != len:
if nread != length:
raise RuntimeError(
f"unable to read full response in child. (We read {nread}, but expected {len})"
f"unable to read full response in child. (We read {nread}, but expected {length})"
)
if nread == 0:
raise EOFError(f"Request socket closed before response was complete ({self.id_counter=})")
Expand Down