Skip to content

Bugfix: StackdriverHook channel and policy assignments when creating/updating notifications and policy's #53131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
potiuk merged 1 commit into from
Jul 10, 2025
Merged

Bugfix: StackdriverHook channel and policy assignments when creating/updating notifications and policy's #53131

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 10 additions & 8 deletions providers/google/src/airflow/providers/google/cloud/hooks/stackdriver.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -261,8 +261,9 @@ def upsert_alert(
channel_name_map = {}

for channel in channels:
# This field is immutable, illegal to specifying non-default UNVERIFIED or VERIFIED, so setting default
channel.verification_status = (
monitoring_v3.NotificationChannel.VerificationStatus.VERIFICATION_STATUS_UNSPECIFIED
monitoring_v3.NotificationChannel.VerificationStatus.VERIFICATION_STATUS_UNSPECIFIED # type: ignore[assignment]
)

if channel.name in existing_channels:
Expand All @@ -274,7 +275,7 @@ def upsert_alert(
)
else:
old_name = channel.name
channel.name = None
del channel.name
new_channel = channel_client.create_notification_channel(
request={"name": f"projects/{project_id}", "notification_channel": channel},
retry=retry,
Expand All @@ -284,8 +285,8 @@ def upsert_alert(
channel_name_map[old_name] = new_channel.name

for policy in policies_:
policy.creation_record = None
policy.mutation_record = None
del policy.creation_record
del policy.mutation_record

for i, channel in enumerate(policy.notification_channels):
new_channel = channel_name_map.get(channel)
Expand All @@ -301,9 +302,9 @@ def upsert_alert(
metadata=metadata,
)
else:
policy.name = None
del policy.name
for condition in policy.conditions:
condition.name = None
del condition.name
policy_client.create_alert_policy(
request={"name": f"projects/{project_id}", "alert_policy": policy},
retry=retry,
Expand Down Expand Up @@ -531,8 +532,9 @@ def upsert_channel(
channels_list.append(NotificationChannel(**channel))

for channel in channels_list:
# This field is immutable, illegal to specifying non-default UNVERIFIED or VERIFIED, so setting default
channel.verification_status = (
monitoring_v3.NotificationChannel.VerificationStatus.VERIFICATION_STATUS_UNSPECIFIED
monitoring_v3.NotificationChannel.VerificationStatus.VERIFICATION_STATUS_UNSPECIFIED # type: ignore[assignment]
)

if channel.name in existing_channels:
Expand All @@ -544,7 +546,7 @@ def upsert_channel(
)
else:
old_name = channel.name
channel.name = None
del channel.name
new_channel = channel_client.create_notification_channel(
request={"name": f"projects/{project_id}", "notification_channel": channel},
retry=retry,
Expand Down