Skip to content

Bugfix/fix mypy samba #53113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jscheffl merged 2 commits into from
Jul 10, 2025
Merged

Bugfix/fix mypy samba #53113

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5ff85f4
Make samba provider compatible with mypy 1.16.1
jscheffl Jul 9, 2025
e289c78
Make samba provider compatible with mypy 1.16.1
jscheffl Jul 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 31 additions & 2 deletions providers/samba/src/airflow/providers/samba/hooks/samba.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,15 +104,17 @@ def listdir(self, path):
def lstat(self, path):
return smbclient.lstat(self._join_path(path), **self._conn_kwargs)

@wraps(smbclient.makedirs)
def makedirs(self, path, exist_ok=False):
self._makedirs(path, exist_ok)

@wraps(smbclient.makedirs)
def _makedirs(self, path, exist_ok):
return smbclient.makedirs(self._join_path(path), exist_ok=exist_ok, **self._conn_kwargs)

@wraps(smbclient.mkdir)
def mkdir(self, path):
return smbclient.mkdir(self._join_path(path), **self._conn_kwargs)

@wraps(smbclient.open_file)
def open_file(
self,
path,
Expand All @@ -125,6 +127,33 @@ def open_file(
desired_access=None,
file_attributes=None,
file_type="file",
):
self._open_file(
path,
mode,
buffering,
encoding,
errors,
newline,
share_access,
desired_access,
file_attributes,
file_type,
)

@wraps(smbclient.open_file)
def _open_file(
self,
path,
mode,
buffering,
encoding,
errors,
newline,
share_access,
desired_access,
file_attributes,
file_type="file",
):
return smbclient.open_file(
self._join_path(path),
Expand Down