Skip to content

Make microsoft azure provider compatible with mypy 1.16.1 #53107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
potiuk merged 3 commits into from
Jul 10, 2025
Merged

Make microsoft azure provider compatible with mypy 1.16.1 #53107

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
91b9a5f
Make microsoft azure provider compatible with mypy 1.16.1
gopidesupavan Jul 9, 2025
e84b58a
Make microsoft azure provider compatible with mypy 1.16.1
gopidesupavan Jul 9, 2025
9918271
Split default_azure_credential into sync and async version
gopidesupavan Jul 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 25 additions & 11 deletions providers/microsoft/azure/src/airflow/providers/microsoft/azure/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,17 +60,14 @@ def _get_default_azure_credential(
*,
managed_identity_client_id: str | None = None,
workload_identity_tenant_id: str | None = None,
use_async: bool = False,
) -> DefaultAzureCredential | AsyncDefaultAzureCredential:
) -> DefaultAzureCredential:
"""
Get DefaultAzureCredential based on provided arguments.

If managed_identity_client_id and workload_identity_tenant_id are provided, this function returns
DefaultAzureCredential with managed identity.
"""
credential_cls: type[AsyncDefaultAzureCredential] | type[DefaultAzureCredential] = (
AsyncDefaultAzureCredential if use_async else DefaultAzureCredential
)
credential_cls: type[DefaultAzureCredential] = DefaultAzureCredential
if managed_identity_client_id and workload_identity_tenant_id:
return credential_cls(
managed_identity_client_id=managed_identity_client_id,
Expand All @@ -80,14 +77,31 @@ def _get_default_azure_credential(
return credential_cls()


get_sync_default_azure_credential: partial[DefaultAzureCredential] = partial(
_get_default_azure_credential, # type: ignore[arg-type]
use_async=False,
)
def _get_async_default_azure_credential(
*,
managed_identity_client_id: str | None = None,
workload_identity_tenant_id: str | None = None,
) -> AsyncDefaultAzureCredential:
"""
Get AsyncDefaultAzureCredential based on provided arguments.

If managed_identity_client_id and workload_identity_tenant_id are provided, this function returns
AsyncDefaultAzureCredential with managed identity.
"""
credential_cls: type[AsyncDefaultAzureCredential] = AsyncDefaultAzureCredential
if managed_identity_client_id and workload_identity_tenant_id:
return credential_cls(
managed_identity_client_id=managed_identity_client_id,
workload_identity_tenant_id=workload_identity_tenant_id,
additionally_allowed_tenants=[workload_identity_tenant_id],
)
return credential_cls()


get_sync_default_azure_credential: partial[DefaultAzureCredential] = partial(_get_default_azure_credential)

get_async_default_azure_credential: partial[AsyncDefaultAzureCredential] = partial(
_get_default_azure_credential, # type: ignore[arg-type]
use_async=True,
_get_async_default_azure_credential
)


Expand Down